* Re: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
@ 2000-10-23 8:18 Sven Wischnowsky
0 siblings, 0 replies; 2+ messages in thread
From: Sven Wischnowsky @ 2000-10-23 8:18 UTC (permalink / raw)
To: zsh-workers
Andrej Borsenkow wrote:
> > + errno == EWOULDBLOCK
>
> Not exactly relevant, but assignment to errno is a bad style. It may well be a
> function (or some non-lvalue entity), espicially in case of threads support.
> Also, I was really surprised recently to hear, that C9X and ISO C++ _require_
> errno to be a macro.
>
> There are probably many other places where errno is assigned to, of course.
> But if we can avoid it - let's do it.
That's a comparison, not an assignment.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
^ permalink raw reply [flat|nested] 2+ messages in thread
* OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin
2000-10-23 7:59 Sven Wischnowsky
@ 2000-10-23 8:15 ` Andrej Borsenkow
0 siblings, 0 replies; 2+ messages in thread
From: Andrej Borsenkow @ 2000-10-23 8:15 UTC (permalink / raw)
To: Sven Wischnowsky, zsh-workers
> + errno == EWOULDBLOCK
Not exactly relevant, but assignment to errno is a bad style. It may well be a
function (or some non-lvalue entity), espicially in case of threads support.
Also, I was really surprised recently to hear, that C9X and ISO C++ _require_
errno to be a macro.
There are probably many other places where errno is assigned to, of course.
But if we can avoid it - let's do it.
-andrej
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-10-23 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-10-23 8:18 OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin Sven Wischnowsky
-- strict thread matches above, loose matches on Subject: below --
2000-10-23 7:59 Sven Wischnowsky
2000-10-23 8:15 ` OT: assignment to errno " Andrej Borsenkow
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).