From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11880 invoked from network); 23 Oct 2000 08:18:14 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 23 Oct 2000 08:18:14 -0000 Received: (qmail 284 invoked by alias); 23 Oct 2000 08:18:09 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 13064 Received: (qmail 276 invoked from network); 23 Oct 2000 08:18:08 -0000 Date: Mon, 23 Oct 2000 10:18:07 +0200 (MET DST) Message-Id: <200010230818.KAA14207@beta.informatik.hu-berlin.de> From: Sven Wischnowsky To: zsh-workers@sunsite.auc.dk In-reply-to: "Andrej Borsenkow"'s message of Mon, 23 Oct 2000 12:15:22 +0400 Subject: Re: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin Andrej Borsenkow wrote: > > + errno == EWOULDBLOCK > > Not exactly relevant, but assignment to errno is a bad style. It may well be a > function (or some non-lvalue entity), espicially in case of threads support. > Also, I was really surprised recently to hear, that C9X and ISO C++ _require_ > errno to be a macro. > > There are probably many other places where errno is assigned to, of course. > But if we can avoid it - let's do it. That's a comparison, not an assignment. Bye Sven -- Sven Wischnowsky wischnow@informatik.hu-berlin.de