From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: Misc. zpty tweaks, plus commentary
Date: Mon, 13 Nov 2000 11:21:32 +0100 (MET) [thread overview]
Message-ID: <200011131021.LAA30936@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: "Bart Schaefer"'s message of Sun, 5 Nov 2000 01:59:58 +0000
Bart Schaefer wrote:
> ...
>
> The problem is that whenever zsh forks a builtin, it closes all descriptors
> numbered higher than 10, which includes the master pty descriptor. So if
> you try to use `zpty -r' or `zpty -w' in a pipeline, or try to put them in
> the background, they'll get "invalid file descriptor" when attempting to
> access the pty. I've played with "hiding" the master fd by zeroing its slot
> in fdtable[], and that does make zpty work correctly, but it also means that
> the master descriptor is still open when running other builtins, which is
> not quite so desirable.
I don't see any simple solution either. Maybe this is yet another
reason for a more sophisticated file-descriptior/blocking/waiting
handling in the core. Not only that modules should be able to register
file-descriptors that should be monitored whenever the shell is
waiting, they should also be able to register handler functions (for
reading, writing, exceptions, closing, etc.).
[ in another message: ]
> On Nov 4, 11:29pm, I wrote:
> }
> } `zpty -w' already was able to stream into the pty (even though that's
> } not documented); e.g. `zpty -w foo < file' writes the entire contents
> } of the file to the pty [...] Now `zpty -r foo' can stream the output
> } as well. Unfortunately, it's still not possible to do both at once.
> }
> } The problem is that whenever zsh forks a builtin, it closes all
> } descriptors numbered higher than 10, which includes the master pty
> } descriptor.
>
> Although a C-code-level fix would be preferable, a workaround has just
> occurred to me: Using a subshell will prevent the descriptors from
> being closed. So with 13116 applied, you should be able to do:
>
> zpty -b foo cat
> yes blah | (zpty -w foo) &
> (zpty -r foo) | less
> zpty -d foo
>
> This reveals that still another remaining problem is that `zpty -w' on a
> blocking pty doesn't stop when the process on the pty is killed. There
> doesn't seem to be any simple fix for this; write() itself is blocked,
> and does not get interrupted with SIGPIPE as would normally occur.
Hm, yes. There might be a solution using the fact that we have a
subshell that we could make ignore SIGHUP (and write something to the
pty or whatever). But I currently can't see how this really helps.
[ and in yet another message: ]
> ...
>
> I haven't done anything about it, but this code clearly expects that
> no '\0' bytes will ever be sent to or received from the pty. That's
> obviously a fallacy; we shouldn't be treating this data as C strings.
Yes and no. For reading, this already worked (the call to metafy()). But
somehow I forgot to do the same for `zpty -w'. The patch fixes this.
> It would appear from the documentation that, with a blocking pty,
> `zpty -r' must always return either 0 or 2. Is this really the case?
> (On my RH5.2 linux system, select() always returns 1 after the pty's
> command has exited, so read_poll() also returns 1 and cmd->fin never
> gets set. read(), however, gets an I/O error (errno == 5), so `zpty -r'
> returns 1 and it's not possible to detect that the command has finished.
Rats. The same here. Why didn't I notice that?
Another reason for not using read_poll(), does anyone see a way to
allow us to find out if a command has exited and still be able to read
the rest of its output?
Bye
Sven
Index: Src/Modules/zpty.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/zpty.c,v
retrieving revision 1.18
diff -u -r1.18 zpty.c
--- Src/Modules/zpty.c 2000/11/11 19:50:29 1.18
+++ Src/Modules/zpty.c 2000/11/13 10:05:24
@@ -562,13 +562,15 @@
ptywrite(Ptycmd cmd, char **args, int nonl)
{
if (*args) {
- char sp = ' ';
+ char sp = ' ', *tmp;
+ int len;
- while (*args)
- if (ptywritestr(cmd, *args, strlen(*args)) ||
+ while (*args) {
+ unmetafy((tmp = dupstring(*args)), &len);
+ if (ptywritestr(cmd, tmp, len) ||
(*++args && ptywritestr(cmd, &sp, 1)))
return 1;
-
+ }
if (!nonl) {
sp = '\n';
if (ptywritestr(cmd, &sp, 1))
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2000-11-13 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-13 10:21 Sven Wischnowsky [this message]
2000-11-13 16:20 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2000-11-04 23:29 Bart Schaefer
2000-11-05 1:59 ` Bart Schaefer
2000-11-05 4:35 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200011131021.LAA30936@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).