zsh-workers
 help / color / mirror / code / Atom feed
From: "E. Jay Berkenbilt" <ejb@ql.org>
To: zsh-workers@sunsite.auc.dk
Subject: trivial patch to _rlogin to make rcp complete more like scp
Date: Sat, 18 Nov 2000 10:37:37 -0500	[thread overview]
Message-ID: <200011181537.KAA06383@soup.ql.org> (raw)


If you say 

scp file hostTAB

where host is something that unambiguously completes to a host, scp
adds a colon to the end of the host.  If you then hit space, the colon
stays.

If you do the same with rcp, the colon disappears after a space.  The
same thing goes with user@.

I think that keeping the colon is the Right Thing (TM) since it
actually means something.  I often do scp file host: just to copy the
file to my top level home directory.  I do the same thing with rcp but
I have to retype the : to keep it from vanishing.

I'm not convinced that this is the right behavior with the @.  In any
case, this patch takes the -q's off of the _alternative call to
prevent this behavior in _rlogin for rcp.  I went ahead and did it for
the @ case as well so that rcp would be consistent with scp, but it
would also have been reasonable to change _scp to add the -q for the @
case....

The only way I could figure this out was to do a careful comparison
between the _rlogin and _ssh code.  The -q flag to _alternative seems
to be either missing from the documentation or very well hidden.

This patch is relative to the current CVS....

I think I may end too many sentences with strings of four dots....

                                Jay


---------------------------------------------------------------------------

--- _rlogin.qdist	Sat Nov 18 10:05:13 2000
+++ _rlogin	Sat Nov 18 10:25:02 2000
@@ -40,12 +40,12 @@
       if compset -P '*:'; then
 	_files && ret=0
       elif compset -P '*@'; then
-        _wanted hosts expl host _rlogin_hosts -S: -q && ret=0
+        _wanted hosts expl host _rlogin_hosts -S: && ret=0
       else
         _alternative \
 	    'files:: _files' \
-	    'hosts:: _rlogin_all_hosts -qS:' \
-	    'users:: _rlogin_users -qS@' && ret=0
+	    'hosts:: _rlogin_all_hosts -S:' \
+	    'users:: _rlogin_users -S@' && ret=0
       fi
     fi
     return ret


             reply	other threads:[~2000-11-18 15:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-18 15:37 E. Jay Berkenbilt [this message]
2000-11-18 16:50 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200011181537.KAA06383@soup.ql.org \
    --to=ejb@ql.org \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).