PATCH: Re: Completion for kill

[Sven Wischnowsky <wischnow@informatik.hu-berlin.de>]

Oliver Kiddle wrote:

> This has just been annoying me: completion for kill insists on doing
> menu completion: from zsh -f + compinit, create a couple of background
> jobs and then type kill %<tab>. After pressing just one tab, menu
> completion is entered with the first job completed in full on the
> command-line. The behaviour I would like is exactly what you get with
> fg %<tab> in the same situation where you need more tabs before menu
> completion is used.
> 
> The situation is caused by _pids which _kill uses along with _jobs.
> None of the possible values of the insert-ids style help. One solution
> is if I add compstate[insert]=unambiguous to the end of _kill. Is there
> a better solution to this. Surely _pids should only be messing about
> with compstate[insert] if pids are the only thing being completed?

Ahem.  Sorry (I use jobs so seldom that I didn't see that...)

Bye
 Sven

Index: Completion/Builtins/_pids
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Builtins/_pids,v
retrieving revision 1.9
diff -u -r1.9 _pids
--- Completion/Builtins/_pids	2000/08/16 07:16:12	1.9
+++ Completion/Builtins/_pids	2001/03/23 15:15:34
@@ -11,7 +11,7 @@
   all=()
   match="*[[:blank:]]${PREFIX}[0-9]#${SUFFIX}[[:blank:]]*[/[:blank:]]${2}*"
   shift 2
-elif [[ "$PREFIX$SUFFIX" = [0-9]# ]]; then
+elif [[ "$PREFIX$SUFFIX" = (%*|[0-9]#) ]]; then
   all=()
   match="*[[:blank:]]${PREFIX}[0-9]#${SUFFIX}[[:blank:]]*"
 else

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de