zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: PATCH: More comments in ztst files
Date: Sun, 25 Mar 2001 00:19:52 +0000	[thread overview]
Message-ID: <20010325001952.44D9F139C6@pwstephenson.fsnet.co.uk> (raw)
In-Reply-To: ""Bart Schaefer""'s message of "Sat, 24 Mar 2001 23:57:14 GMT." <1010324235714.ZM31898@candle.brasslantern.com>

Bart wrote:
>   # it doesn't *say* these are case-insensitive without i...
>   # I think this is a bug.
> 
> Where "these" are ${(o)...} and ${(O)...}.  The manual does in fact say
> that (i) means sort case-insensitively with (o).  By implication, sorting
> should be case-sensitive without it, right?  The results seem to be in
> case-sensitive order, so I'm not sure what was up with this comment.

There was some argy bargy about the effect of locales, which caused some
confusion about this: in some locales (even English language ones) the
sorting was automatically case-insensitive.  We now reset LC_ALL to C in
ztst.zsh.  But this doesn't seem to be enough.

- I I be could programme recorded that watching
  be could I I programme recorded that watching
! watching that recorded programme could be I I
  watching that recorded programme I I could be
--- 1,4 ----
  be could I I programme recorded that watching
! be could I I programme recorded that watching
! watching that recorded programme I I could be
  watching that recorded programme I I could be

This is because Chmouel and company have done the job more thoroughly this
time (Mandrake 7.2):

exported LC_COLLATE=en_GB             # form orderly bus queues
exported LC_CTYPE=en_GB
exported LC_MESSAGES=en_GB            # don't say `have a nice day'
exported LC_MONETARY=en_GB            # devalue everything in sight
exported LC_NUMERIC=en_GB
exported LC_TIME=en_GB

The patch below fixes LC_COLLATE, too.

> Peter must have really been pining for William Dalrymple at this point.

Oh, dear.  I don't think I've ever really read what I wrote before.

Index: Test/ztst.zsh
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/ztst.zsh,v
retrieving revision 1.5
diff -u -r1.5 ztst.zsh
--- Test/ztst.zsh	2000/06/07 09:02:24	1.5
+++ Test/ztst.zsh	2001/03/25 00:16:09
@@ -25,6 +25,7 @@
 # Ensure the locale does not screw up sorting.  Don't supply a locale
 # unless there's one set, to minimise problems.
 [[ -n $LC_ALL ]] && LC_ALL=C
+[[ -n $LC_COLLATE ]] && LC_COLLATE=C
 [[ -n $LANG ]] && LANG=C
 
 # Set the module load path to correspond to this build of zsh.

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk


      reply	other threads:[~2001-03-25  0:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-24 23:57 Bart Schaefer
2001-03-25  0:19 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010325001952.44D9F139C6@pwstephenson.fsnet.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).