From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: PATCH: Re: Completing option/value pairs without space
Date: Mon, 26 Mar 2001 12:01:37 +0200 (MET DST) [thread overview]
Message-ID: <200103261001.MAA13793@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Oliver Kiddle's message of Sat, 24 Mar 2001 15:03:52 +0000
Oliver Kiddle wrote:
> Sven Wischnowsky wrote:
> >
> > And one remark to all -workers: with the function below completion
> > after `ecasound -efs:<TAB>' makes _arguments report (and show) `-efs:'
> > as a possible completion. That's correct somehow, but looks very
> > weird in this case. Hm.
>
> I don't really understand why it is "correct somehow". It seems to occur
> only with options ending in a colon and there shouldn't be anything
> special about the colon, only that if not quoted, it would mean
> something different. Isn't this _arguments failing to account for the
> quoting somewhere?
Argh. Yes, you are right. Why did I think I had tested that?
The problem was that the C-code didn't strip the backslashes before
colon before putting options into their own xor-lists. That made
later tests fail.
Bye
Sven
Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.45
diff -u -r1.45 computil.c
--- Src/Zle/computil.c 2001/01/16 13:44:20 1.45
+++ Src/Zle/computil.c 2001/03/26 10:00:58
@@ -821,7 +821,7 @@
xor = (char **) zalloc(2 * sizeof(char *));
xor[1] = NULL;
}
- xor[xnum] = ztrdup(name);
+ xor[xnum] = ztrdup(rembslashcolon(name));
}
if (c == ':') {
/* There's at least one argument. */
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
reply other threads:[~2001-03-26 10:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200103261001.MAA13793@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).