From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: various minor fixes
Date: Mon, 2 Apr 2001 11:03:57 +0200 (MET DST) [thread overview]
Message-ID: <200104020903.LAA04980@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: Oliver Kiddle's message of Sun, 01 Apr 2001 16:13:19 +0100
Oliver Kiddle wrote:
> ...
>
> In the process, I noticed a bug with the -S option to _arguments: bzip2
> --<tab> now says 'no more arguments' where I would expect it to complete
> long options. _arguments -S should look for '--' as a complete, finished
> word.
Exactly. Hance easy to fix.
> Also, gzip -<tab> seems to move the cursor back over the minus.\x13
This was yet another cursor-positioning bug caused by match specs. I
copied the wrong test in join_clines().
Bye
Sven
Index: Src/Zle/compmatch.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compmatch.c,v
retrieving revision 1.33
diff -u -r1.33 compmatch.c
--- Src/Zle/compmatch.c 2001/03/06 11:31:21 1.33
+++ Src/Zle/compmatch.c 2001/04/02 09:02:15
@@ -2076,7 +2076,8 @@
if ((diff = sub_join(o, n, tn, 0))) {
o->flags = (o->flags & ~CLF_MISS) | of;
- if (po) {
+ if (po && po->prefix &&
+ cmp_anchors(o, po, 0)) {
po->flags |= CLF_MISS;
po->max += diff;
}
Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.46
diff -u -r1.46 computil.c
--- Src/Zle/computil.c 2001/03/26 10:02:26 1.46
+++ Src/Zle/computil.c 2001/04/02 09:02:16
@@ -1316,7 +1316,7 @@
doff = state.singles = arglast = 0;
if (ca_inactive(d, argxor, cur, 0) ||
- ((d->flags & CDF_SEP) && !strcmp(line, "--"))) {
+ ((d->flags & CDF_SEP) && cur != compcurrent && !strcmp(line, "--"))) {
if (ca_inactive(d, NULL, cur, 1))
return 1;
continue;
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next reply other threads:[~2001-04-02 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-02 9:03 Sven Wischnowsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-04-01 15:13 Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104020903.LAA04980@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).