zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: reverse string subscripting
Date: Fri, 6 Apr 2001 09:35:57 +0200 (MET DST)	[thread overview]
Message-ID: <200104060735.JAA11365@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <1010405180950.ZM9683@candle.brasslantern.com>

Bart Schaefer wrote:

> ...
> 
> Note the (r) is forward pattern matching, not reverse; (R) is reverse.
> Your patch appears to have fixed the bug only for the forward direction:

Ahem.

Bye
  Sven

Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.33
diff -u -r1.33 params.c
--- Src/params.c	2001/04/05 11:24:17	1.33
+++ Src/params.c	2001/04/06 07:35:07
@@ -1118,7 +1118,7 @@
 		    if (a2) {
 			if (down) {
 			    if (!hasbeg)
-				beg = len - 1;
+				beg = len;
 			    for (r = beg, t = d + beg; t >= d; r--, t--) {
 				sav = *t;
 				*t = '\0';
@@ -1143,7 +1143,7 @@
 		    } else {
 			if (down) {
 			    if (!hasbeg)
-				beg = len - 1;
+				beg = len;
 			    for (r = beg + 1, t = d + beg; t >= d; r--, t--) {
 				if (pattry(pprog, t) &&
 				    !--num)

-- 
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


      reply	other threads:[~2001-04-06  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-05 11:22 Sven Wischnowsky
2001-04-05 16:15 ` PATCH: 3.0.8 " Bart Schaefer
2001-04-05 18:09 ` Bart Schaefer
2001-04-06  7:35   ` Sven Wischnowsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104060735.JAA11365@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).