From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-13916-mason-zsh=primenet.com.au@sunsite.dk>
Received: (qmail 24804 invoked from network); 6 Apr 2001 07:36:05 -0000
Received: from sunsite.dk (130.225.51.30)
  by ns1.primenet.com.au with SMTP; 6 Apr 2001 07:36:05 -0000
Received: (qmail 28396 invoked by alias); 6 Apr 2001 07:36:00 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
X-Seq: 13916
Received: (qmail 28384 invoked from network); 6 Apr 2001 07:36:00 -0000
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
Date: Fri, 6 Apr 2001 09:35:57 +0200 (MET DST)
Message-Id: <200104060735.JAA11365@beta.informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: reverse string subscripting
In-Reply-To: <1010405180950.ZM9683@candle.brasslantern.com>

Bart Schaefer wrote:

> ...
> 
> Note the (r) is forward pattern matching, not reverse; (R) is reverse.
> Your patch appears to have fixed the bug only for the forward direction:

Ahem.

Bye
  Sven

Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.33
diff -u -r1.33 params.c
--- Src/params.c	2001/04/05 11:24:17	1.33
+++ Src/params.c	2001/04/06 07:35:07
@@ -1118,7 +1118,7 @@
 		    if (a2) {
 			if (down) {
 			    if (!hasbeg)
-				beg = len - 1;
+				beg = len;
 			    for (r = beg, t = d + beg; t >= d; r--, t--) {
 				sav = *t;
 				*t = '\0';
@@ -1143,7 +1143,7 @@
 		    } else {
 			if (down) {
 			    if (!hasbeg)
-				beg = len - 1;
+				beg = len;
 			    for (r = beg + 1, t = d + beg; t >= d; r--, t--) {
 				if (pattry(pprog, t) &&
 				    !--num)

-- 
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de