zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: mapfile (Re: More ramblings Re: zsh/termcap and zsh/terminfo modules)
Date: Wed, 11 Apr 2001 01:05:54 +0100	[thread overview]
Message-ID: <20010411000554.DA41F139CD@pwstephenson.fsnet.co.uk> (raw)
In-Reply-To: ""Bart Schaefer""'s message of "Tue, 10 Apr 2001 18:08:50 -0000." <1010410180851.ZM18574@candle.brasslantern.com>

Bart wrote:
> Hmm, well, could this possibly be a result of scanpmmapfile() relying on
> the static buffer from metafy() that is returned by zreaddir() ?
> 
> I'm not sure whether the right thing to do about that is to dupstring() ?

That seems to work.  I'm now off for Easter.  Stay alert!

Index: Src/Modules/mapfile.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/mapfile.c,v
retrieving revision 1.4
diff -u -r1.4 mapfile.c
--- Src/Modules/mapfile.c	2000/06/09 15:37:05	1.4
+++ Src/Modules/mapfile.c	2001/04/11 00:02:41
@@ -318,6 +318,7 @@
 	 * we always read the entire contents of every single file
 	 * in the directory into memory.  Hence just leave it empty.
 	 */
+	pm.nam = dupstring(pm.nam);
 	pm.u.str = "";
 	func((HashNode) &pm, flags);
     }

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk


  reply	other threads:[~2001-04-11  0:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-05  0:15 zsh/termcap and zsh/terminfo modules Bart Schaefer
2001-04-05  5:48 ` Andrej Borsenkow
2001-04-05 13:58   ` Clint Adams
2001-04-05 14:06     ` Andrej Borsenkow
2001-04-06 18:39     ` Bart Schaefer
2001-04-09 13:12       ` Clint Adams
2001-04-09 15:45         ` PATCH: " Bart Schaefer
2001-04-09 15:52           ` Clint Adams
2001-04-09 16:09             ` Bart Schaefer
2001-04-09 16:24               ` More ramblings " Bart Schaefer
2001-04-09 16:28                 ` Peter Stephenson
2001-04-10 17:35                   ` mapfile (Re: More ramblings Re: zsh/termcap and zsh/terminfo modules) Bart Schaefer
2001-04-10 17:40                     ` Peter Stephenson
2001-04-10 18:08                       ` Bart Schaefer
2001-04-11  0:05                         ` Peter Stephenson [this message]
2001-04-09 16:58                 ` More ramblings Re: zsh/termcap and zsh/terminfo modules Bart Schaefer
2001-04-09 17:34               ` PATCH: " Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010411000554.DA41F139CD@pwstephenson.fsnet.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).