zsh-workers
 help / color / mirror / code / Atom feed
From: "Oliver Kiddle" <okiddle@yahoo.co.uk>
To: zsh-workers@sunsite.dk
Subject: Re: Slash after directory number in cd completion?
Date: Thu, 12 Apr 2001 12:34:28 +0100 (BST)	[thread overview]
Message-ID: <20010412113428.86398.qmail@web9307.mail.yahoo.com> (raw)
In-Reply-To: <1010411220641.ZM20380@candle.brasslantern.com>

--- Bart Schaefer <schaefer@candle.brasslantern.com> wrote:

> It's _directory_stack calling `compadd -qS/ ...' via _wanted at line
right.

> I think the line
> 
> [[ $PREFIX = [-+]* ]] || return 1

That is needed so that the directory stack is only completed after a -
or + because the matches are added as 0, 1, 2, etc instead of -0, -1,
-2, etc.

> needs to be something/somewhere else.  Perhaps like this?  This seems
> to
> work as I expect, but Sven should confirm it when he's back next
> week.

It doesn't work as I'd expect - it adds the directory stack as
completions without the - and +.

_tilde now supplies the -qS/ option to _directory_stack and this is the
only time it is needed so I believe the following patch is correct
(this is instead of Bart's as opposed to on top of it).

I actually think the correct patch would be to remove the whole if,
then else because it is done in _tilde and isn't otherwise needed. I've
left it for the time being though.

Oliver

Index: Completion/Zsh/Type/_directory_stack
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Zsh/Type/_directory_stack,v
retrieving revision 1.1
diff -u -r1.1 _directory_stack
--- Completion/Zsh/Type/_directory_stack        2001/04/02 11:20:31    
1.1
+++ Completion/Zsh/Type/_directory_stack        2001/04/12 11:32:35
@@ -14,7 +14,7 @@
   SUFFIX="${SUFFIX%%/*}"
   suf=(-S '')
 else
-  suf=(-qS/)
+  suf=()
 fi

 ### we decided against this, for now...


____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie


  reply	other threads:[~2001-04-12 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-11 20:10 PATCH: completion for a couple more builtins Oliver Kiddle
2001-04-11 21:30 ` Slash after directory number in cd completion? Andrej Borsenkow
2001-04-11 22:06   ` Bart Schaefer
2001-04-12 11:34     ` Oliver Kiddle [this message]
2001-04-12 18:08       ` Bart Schaefer
2001-04-17  8:52       ` Sven Wischnowsky
2001-04-11 22:15 ` PATCH: completion for a couple more builtins Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010412113428.86398.qmail@web9307.mail.yahoo.com \
    --to=okiddle@yahoo.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).