From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH (?): Re: Automatic hash -d
Date: Wed, 18 Apr 2001 10:29:00 +0200 (MET DST) [thread overview]
Message-ID: <200104180829.KAA08699@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <1010418055634.ZM28577@candle.brasslantern.com>
Bart Schaefer wrote:
> ...
>
> So how's this look?
Good, I think you can commit it.
> I'm a little worried about "$compstate[quote]" != \"
> but that's what was there before, and I don't really understand why I'm
> worried (nor why it's there, for that matter; the -z "$compstate[quote]"
> test in the next branch makes more sense to me).
I think it's a typo. And I couldn't find the message that added it in
the archive, searching for `compstate\[quote\]'. That test once was
`-z $compstate[quote]', too, which wasn't right either.
It should test $compstate[quote] != \', because $s aren't expanded
inside single quotes (try it with completion after
foo=bar
echo '$foo/<TAB>
where there exists a directory named `$foo').
> ...
>
> Ideally, the code in _path_files would first peel off the ~notauser and
> check that for errors, and then discover that the prefix still contains
> an expansion and try to shift more of it into linepath and realpath and
> check *that* for errors; but I wasn't prepared to do that much violence
> to _path_files.
Yes, that would be better. I might have a look once your patch is
committed, don't have the time now.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
prev parent reply other threads:[~2001-04-18 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-13 2:08 Wayne Davison
2001-04-13 2:30 ` "keep-prefix true" feature request Wayne Davison
2001-04-13 4:50 ` Bart Schaefer
2001-04-13 5:09 ` Automatic hash -d Bart Schaefer
2001-04-13 8:01 ` Wayne Davison
2001-04-13 15:38 ` Bart Schaefer
2001-04-13 16:47 ` Bart Schaefer
2001-04-17 9:04 ` Sven Wischnowsky
2001-04-18 5:56 ` PATCH (?): " Bart Schaefer
2001-04-18 8:29 ` Sven Wischnowsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200104180829.KAA08699@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).