From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19184 invoked from network); 18 Apr 2001 08:29:09 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 18 Apr 2001 08:29:09 -0000 Received: (qmail 24138 invoked by alias); 18 Apr 2001 08:29:04 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 14009 Received: (qmail 24097 invoked from network); 18 Apr 2001 08:29:03 -0000 From: Sven Wischnowsky Date: Wed, 18 Apr 2001 10:29:00 +0200 (MET DST) Message-Id: <200104180829.KAA08699@beta.informatik.hu-berlin.de> To: zsh-workers@sunsite.dk Subject: Re: PATCH (?): Re: Automatic hash -d In-Reply-To: <1010418055634.ZM28577@candle.brasslantern.com> Bart Schaefer wrote: > ... > > So how's this look? Good, I think you can commit it. > I'm a little worried about "$compstate[quote]" != \" > but that's what was there before, and I don't really understand why I'm > worried (nor why it's there, for that matter; the -z "$compstate[quote]" > test in the next branch makes more sense to me). I think it's a typo. And I couldn't find the message that added it in the archive, searching for `compstate\[quote\]'. That test once was `-z $compstate[quote]', too, which wasn't right either. It should test $compstate[quote] != \', because $s aren't expanded inside single quotes (try it with completion after foo=bar echo '$foo/ where there exists a directory named `$foo'). > ... > > Ideally, the code in _path_files would first peel off the ~notauser and > check that for errors, and then discover that the prefix still contains > an expansion and try to shift more of it into linepath and realpath and > check *that* for errors; but I wasn't prepared to do that much violence > to _path_files. Yes, that would be better. I might have a look once your patch is committed, don't have the time now. Bye Sven -- Sven Wischnowsky wischnow@informatik.hu-berlin.de