zsh-workers
 help / color / mirror / code / Atom feed
From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: destructive list-expand
Date: Tue, 15 May 2001 11:28:50 +0200 (MET DST)	[thread overview]
Message-ID: <200105150928.LAA09646@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <1010515053225.ZM11358@candle.brasslantern.com>

Bart Schaefer wrote:

> ...
> 
> } I don't quite see where the quotes are getting stripped off, unless it's
> } actually get_comp_string() that's at fault.
> 
> Guess what ... around line 1376 of zle_tricky.c ... I'm at a loss for
> what that code is meant to be doing or when it is ever the right thing.

All this is so disgusting... sigh.

That code is there to turn turn null tokens inside parameter expansions
into their original forms (single or double quotes) so that later code
can use them correctly because they won't be removed in the following
loop.

Unfortunately, this will only be done if we are completing *inside* the
parameter expansion (the parameter name). I'll have to try if it is
correct to change that part of the code to re-install quotes anywhere in
a parameter expansion in the word (well, it sounds right, doesn't it?).

But even with that there's still something fishy with list-expand which
I haven't any further into yet. And with _expand and functions that call
it:

  beta% e=( '${(M)${(f)"$(<x)"}:#*2*}' )
  beta% echo ${(e)e}
   
  beta% echo ${(e)~e}
  111 222 333
  beta%

Oh well. Anyone interested in fixing that?


No patch yet...

Bye
  Sven


-- 
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


  reply	other threads:[~2001-05-15  9:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-15  2:30 Clint Adams
2001-05-15  4:48 ` Bart Schaefer
2001-05-15  5:32   ` Bart Schaefer
2001-05-15  9:28     ` Sven Wischnowsky [this message]
2001-05-15 13:48       ` Sven Wischnowsky
2001-05-15 13:57         ` Peter Stephenson
2001-05-15 14:18           ` Sven Wischnowsky
2001-05-15 14:41             ` Bart Schaefer
2001-05-15 15:05               ` Bart Schaefer
2001-05-16 10:24               ` Sven Wischnowsky
2001-05-16 11:05                 ` Peter Stephenson
2001-05-16 12:49                 ` Sven Wischnowsky
2001-05-16 19:10                   ` Quoting and ${(e)param} (was Re: destructive list-expand) Bart Schaefer
2001-05-17  9:03                     ` Sven Wischnowsky
2001-05-18  9:55                       ` Bart Schaefer
2001-05-18 12:36                         ` PATCH: " Sven Wischnowsky
2001-05-16 19:14                 ` destructive list-expand Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200105150928.LAA09646@beta.informatik.hu-berlin.de \
    --to=wischnow@informatik.hu-berlin.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).