dynamic linking on OpenBSD

dynamic linking on OpenBSD

[David Lebel]

Hello,
 
I'm the maintainer of the zsh port for OpenBSD in its ports tree, and
the way configure setup dynamic linking for OpenBSD is wrong.  Well, it
does work for most of the OpenBSD platform, but its not correct.
DLLDFLAGS should be "-shared -fPIC" and the linker should be ${CC} not
ld.
 
Here is a trivial diff to the configure script so it works correctly.
Adapt to your liking.
 
Ciao,
  ...David

$OpenBSD$
--- configure.orig	Tue Jun  5 18:51:53 2001
+++ configure	Tue Jun  5 18:58:37 2001
@@ -6767,8 +6767,16 @@ echo "$ac_t""$zsh_cv_sys_elf" 1>&6
       ;;
     esac
   else
-    DLLD="${DLLD=ld}"
-    DLLDARG=""
+    case "$host" in
+      *openbsd*)
+	DLLD="${DLLD=$CC}"
+	DLLDARG="${LDARG}"
+      ;;
+      * )
+	DLLD="${DLLD=ld}"
+	DLLDARG=""
+      ;;
+    esac
   fi
   if test -n "$GCC"; then
     DLCFLAGS="${DLCFLAGS=-fpic}"
@@ -6787,7 +6795,7 @@ echo "$ac_t""$zsh_cv_sys_elf" 1>&6
     netbsd*)      DLLDFLAGS="${DLLDFLAGS=${DLLDARG}-x -shared --whole-archive}" ;;
     aix*)         DLLDFLAGS="${DLLDFLAGS=-G -bexpall -lc}" ;;
     solaris*|sysv4*|esix*) DLLDFLAGS="${DLLDFLAGS=-G}" ;;
-    openbsd*)     DLLDFLAGS="${DLLDFLAGS=-Bshareable}" ;;
+    openbsd*)     DLLDFLAGS="${DLLDFLAGS=-shared -fPIC}" ;;
   esac
   case "$host" in
     *-hpux*)  EXTRA_LDFLAGS="${EXTRA_LDFLAGS=-Wl,-E}" ;;

-- 
// david lebel <lebel@{lebel.org,nobiaze.com,openbsd.org}> //
// http://www.lebel.org/           http://www.nobiaze.com/ //
// pgp: 3633 6999 D47E 73ED 099F  4341 08A4 8E48 EF56 61D1 //

RE: dynamic linking on OpenBSD

[Andrej Borsenkow]

>
> I'm the maintainer of the zsh port for OpenBSD in its ports tree, and
> the way configure setup dynamic linking for OpenBSD is wrong.  Well, it
> does work for most of the OpenBSD platform, but its not correct.
> DLLDFLAGS should be "-shared -fPIC" and the linker should be ${CC} not
> ld.
>
> Here is a trivial diff to the configure script so it works correctly.
> Adapt to your liking.
>

1. Could you please send diff against configure.in not configure? We do not
keep configure in CVS and it is hard to backport it. Even better, update to
current CVS and diff against zshconfig.ac.

2. Your patch looks like OpenBSD does not use ELF. Is it really the case?

-andrej

Re: dynamic linking on OpenBSD

[David Lebel]

Quoting Andrej Borsenkow (Andrej.Borsenkow@mow.siemens.ru):
> 1. Could you please send diff against configure.in not configure? We do not
> keep configure in CVS and it is hard to backport it. Even better, update to
> current CVS and diff against zshconfig.ac.
> 
> 2. Your patch looks like OpenBSD does not use ELF. Is it really the case?

It does on some platform use ELF.  On other (the majority), its a.out.
By using ${CC} -shared -fPIC is a sure way to generate a proper .so
across all the platforms (be it ELF or a.out).

Here is the diff against configure.in:

$OpenBSD$
--- configure.in.orig	Tue Jun  5 18:52:48 2001
+++ configure.in	Tue Jun  5 19:00:31 2001
@@ -1595,6 +1595,16 @@ char *argv[];
       ;;
     esac
   else
+    case "$host" in
+      *openbsd*)
+	DLLD="${DLLD=$CC}"
+	DLLDARG="${LDARG}"
+      ;;
+      * )
+	DLLD="${DLLD=ld}"
+	DLLDARG=""
+      ;;
+    esac
     DLLD="${DLLD=ld}"
     DLLDARG=""
   fi
@@ -1615,7 +1625,7 @@ char *argv[];
     netbsd*)      DLLDFLAGS="${DLLDFLAGS=${DLLDARG}-x -shared --whole-archive}" ;;
     aix*)         DLLDFLAGS="${DLLDFLAGS=-G -bexpall -lc}" ;;
     solaris*|sysv4*|esix*) DLLDFLAGS="${DLLDFLAGS=-G}" ;;
-    openbsd*)     DLLDFLAGS="${DLLDFLAGS=-Bshareable}" ;;
+    openbsd*)     DLLDFLAGS="${DLLDFLAGS=-shared -fPIC}" ;;
   esac
   case "$host" in
     *-hpux*)  EXTRA_LDFLAGS="${EXTRA_LDFLAGS=-Wl,-E}" ;;

Ciao,
  ...David

-- 
// david lebel <lebel@{lebel.org,nobiaze.com,openbsd.org}> //
// http://www.lebel.org/           http://www.nobiaze.com/ //
// pgp: 3633 6999 D47E 73ED 099F  4341 08A4 8E48 EF56 61D1 //

RE: dynamic linking on OpenBSD

[Andrej Borsenkow]

> Here is a trivial diff to the configure script so it works correctly.

Applied. Should it go into stable 4.0.x as well?

> Adapt to your liking.
>  

Huh? You are the boss here :-)

-andrej

Re: dynamic linking on OpenBSD

[David Lebel]

Quoting Andrej Borsenkow (Andrej.Borsenkow@mow.siemens.ru):
> > Here is a trivial diff to the configure script so it works correctly.
> 
> Applied. Should it go into stable 4.0.x as well?

It should.  It will allow me to remove the patch from zsh port.

Ciao,
  ...David

-- 
// david lebel <lebel@{lebel.org,nobiaze.com,openbsd.org}> //
// http://www.lebel.org/           http://www.nobiaze.com/ //
// pgp: 3633 6999 D47E 73ED 099F  4341 08A4 8E48 EF56 61D1 //