From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: Completion for AUTO_CD
Date: Thu, 21 Jun 2001 12:30:53 +0200 (MET DST) [thread overview]
Message-ID: <200106211030.MAA03537@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <3B31CAE9.CBBE1E30@u.genie.co.uk>
Oliver Kiddle wrote:
> Bart Schaefer wrote:
> >
> > This should be pretty self-explanatory, except for the fact that it's
> > named _autocd because _command is pre-empted for the `command' builtin.
>
> I'm not too keen on the name. I'd suggest using _command and renaming
> the existing _command, perhaps to _command_builtin (we have an
> _jobs_builtin).
Hmhm, seems sensible.
> My initial thought on seeing your patch was that completion for autocd
> already works. This is because of the line in _command_names which adds
> executable files and directories. This is there for completing commands
> by specifying the full path to them. It is unfortunate that we now get
> the directories twice but I can't think of a simple fix.
I was about to mention the same when this mail came. The only thing I
can think of is to make _command_names use only -g, not -/ (it will
revert to directory completion if there is no executable anyway). Or
maybe do that only if autocd is set and _command_names is called from
_autocd. Or something.
> _cd should also possibly be adding usernames and parameters for the
> cdablevars option.
>
> > On a semi-related note, why doesn't _command call `_command_names -e'?
>
> Probably because it pre-dates it.
I think that's the reason, yes. That plus oversight.
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next prev parent reply other threads:[~2001-06-21 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-21 9:17 Bart Schaefer
2001-06-21 9:54 ` Peter Stephenson
2001-06-21 10:22 ` Oliver Kiddle
2001-06-21 10:30 ` Sven Wischnowsky [this message]
2001-06-21 10:50 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200106211030.MAA03537@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).