From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29679 invoked from network); 21 Jun 2001 10:32:43 -0000 Received: from sunsite.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 21 Jun 2001 10:32:43 -0000 Received: (qmail 3723 invoked by alias); 21 Jun 2001 10:32:03 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 15026 Received: (qmail 3683 invoked from network); 21 Jun 2001 10:32:02 -0000 From: Sven Wischnowsky Date: Thu, 21 Jun 2001 12:30:53 +0200 (MET DST) Message-Id: <200106211030.MAA03537@beta.informatik.hu-berlin.de> To: zsh-workers@sunsite.dk Subject: Re: PATCH: Completion for AUTO_CD In-Reply-To: <3B31CAE9.CBBE1E30@u.genie.co.uk> Oliver Kiddle wrote: > Bart Schaefer wrote: > > > > This should be pretty self-explanatory, except for the fact that it's > > named _autocd because _command is pre-empted for the `command' builtin. > > I'm not too keen on the name. I'd suggest using _command and renaming > the existing _command, perhaps to _command_builtin (we have an > _jobs_builtin). Hmhm, seems sensible. > My initial thought on seeing your patch was that completion for autocd > already works. This is because of the line in _command_names which adds > executable files and directories. This is there for completing commands > by specifying the full path to them. It is unfortunate that we now get > the directories twice but I can't think of a simple fix. I was about to mention the same when this mail came. The only thing I can think of is to make _command_names use only -g, not -/ (it will revert to directory completion if there is no executable anyway). Or maybe do that only if autocd is set and _command_names is called from _autocd. Or something. > _cd should also possibly be adding usernames and parameters for the > cdablevars option. > > > On a semi-related note, why doesn't _command call `_command_names -e'? > > Probably because it pre-dates it. I think that's the reason, yes. That plus oversight. Bye Sven -- Sven Wischnowsky wischnow@informatik.hu-berlin.de