From: Clint Adams <clint@zsh.org>
To: Bart Schaefer <schaefer@candle.brasslantern.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: zsh/pcre module docs
Date: Tue, 3 Jul 2001 13:32:30 -0400 [thread overview]
Message-ID: <20010703133230.A5697@dman.com> (raw)
In-Reply-To: <1010703170319.ZM14785@candle.brasslantern.com>; from schaefer@candle.brasslantern.com on Tue, Jul 03, 2001 at 05:03:19PM +0000
> Wouldn't it have been better to put these in the $match array (or into
> some other named array) the way that backrefs in glob patterns do?
Yes.
> pcre_match ...
> set - "$match[@]" # or whatever it is named
>
> For comlete generality, pcre_match could take the name of the array to set
> as an argument; then the above could be accomplished with
>
> pcre_match -a argv ...
Both are implemented, though now you can pass a second argument to pcre_match
that will be ignored.
Index: Doc/Zsh/mod_pcre.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/mod_pcre.yo,v
retrieving revision 1.2
diff -u -r1.2 mod_pcre.yo
--- Doc/Zsh/mod_pcre.yo 2001/07/03 16:52:35 1.2
+++ Doc/Zsh/mod_pcre.yo 2001/07/03 17:30:05
@@ -15,12 +15,13 @@
matching.
)
findex(pcre_match)
-item(tt(pcre_match) var(string))(
+item(tt(pcre_match) [ tt(-a) var(arr) ] var(string))(
Returns successfully if tt(string) matches the previously-compiled
PCRE.
If the expression captures substrings within parentheses,
-tt(pcre_match) will set the positional parameters to
-those substrings, starting with $1 for the first.
+tt(pcre_match) will set the array var($match) to those
+substrings, unless the tt(-a) option is given, in which
+case it will set the array var(arr).
)
enditem()
Index: Src/Modules/pcre.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/pcre.c,v
retrieving revision 1.2
diff -u -r1.2 pcre.c
--- Src/Modules/pcre.c 2001/07/03 16:42:36 1.2
+++ Src/Modules/pcre.c 2001/07/03 17:30:05
@@ -90,8 +90,16 @@
bin_pcre_match(char *nam, char **args, char *ops, int func)
{
int ret, capcount, *ovec, ovecsize;
- char **captures;
+ char **captures, **matches, *receptacle = NULL;
+ if(ops['a']) {
+ receptacle = *args++;
+ if(!*args) {
+ zwarnnam(nam, "not enough arguments", NULL, 0);
+ return 1;
+ }
+ }
+
if (pcre_fullinfo(pcre_pattern, pcre_hints, PCRE_INFO_CAPTURECOUNT, &capcount))
{
zwarnnam(nam, "error in fullinfo", NULL, 0);
@@ -107,9 +115,12 @@
else if (ret==PCRE_ERROR_NOMATCH) return 1; /* no match */
else if (ret>0) {
if(!pcre_get_substring_list(*args, ovec, ret, (const char ***)&captures)) {
-
- freearray(pparams);
- pparams = zarrdup(&captures[1]); /* first one would be entire string */
+
+ matches = zarrdup(&captures[1]); /* first one would be entire string */
+ if (receptacle == NULL)
+ setaparam("match", matches);
+ else
+ setaparam(receptacle, matches);
pcre_free_substring_list((const char **)captures);
return 0;
@@ -128,7 +139,7 @@
#ifdef HAVE_PCRE_STUDY
BUILTIN("pcre_study", 0, bin_pcre_study, 0, 0, 0, NULL, NULL),
#endif
- BUILTIN("pcre_match", 0, bin_pcre_match, 1, 1, 0, NULL, NULL)
+ BUILTIN("pcre_match", 0, bin_pcre_match, 1, 2, 0, "a", NULL)
};
/**/
prev parent reply other threads:[~2001-07-03 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-03 16:51 Clint Adams
2001-07-03 17:03 ` Bart Schaefer
2001-07-03 17:32 ` Clint Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010703133230.A5697@dman.com \
--to=clint@zsh.org \
--cc=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).