From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: RE: Preserve initial // in path name completion
Date: Fri, 6 Jul 2001 12:41:30 +0200 (MET DST) [thread overview]
Message-ID: <200107061041.MAA12536@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <004f01c10607$02c00180$21c9ca95@mow.siemens.ru>
Andrej Borsenkow wrote:
> ...
>
> To my immense surprise even with preserve-prefix unset (but with your patch
> and suitably set fake-files) and squeeze-slashes it happily completed inside
> UNC paths, even respecting all matchers. Looks, like fake-files win?
Err... the patch shouldn't make a difference with the style set, does it
work without the patch, too? (And with the patch below.)
> ...
>
> This obviously happens only with root$; any other share I've tried works.
This was a more general problem because the test for parameter
expansions in the string to complete didn't check if the `$' was
preceded by a backslash. Fix below. I'll commit it (to the stable
branch, too).
Bye
Sven
Index: Completion/Unix/Type/_path_files
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_path_files,v
retrieving revision 1.6
diff -u -r1.6 _path_files
--- Completion/Unix/Type/_path_files 2001/06/18 09:53:17 1.6
+++ Completion/Unix/Type/_path_files 2001/07/06 10:40:04
@@ -190,7 +190,7 @@
# Now let's have a closer look at the string to complete.
-if [[ "$pre" = [^][*?#^\|\<\>]#(\`[^\`]#\`|\$)*/* && "$compstate[quote]" != \' ]]; then
+if [[ "$pre" = [^][*?#^\|\<\>\\]#(\`[^\`]#\`|\$)*/* && "$compstate[quote]" != \' ]]; then
# If there is a parameter expansion in the word from the line, we try
# to complete the beast by expanding the prefix and completing anything
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
next prev parent reply other threads:[~2001-07-06 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-06 5:14 Andrej Borsenkow
2001-07-06 9:24 ` Sven Wischnowsky
2001-07-06 10:32 ` Andrej Borsenkow
2001-07-06 10:41 ` Sven Wischnowsky [this message]
2001-07-06 11:03 ` Andrej Borsenkow
2001-07-06 11:16 ` Andrej Borsenkow
2001-07-06 12:22 ` Sven Wischnowsky
2001-07-06 12:34 ` Andrej Borsenkow
2001-07-13 12:22 ` Andrej Borsenkow
2001-07-17 9:02 ` PATCH: " Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200107061041.MAA12536@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).