location of pcre.h

location of pcre.h

[Adam Spiers]

On my RedHat 7.0 system, pcre.h is in /usr/include/pcre, not
/usr/include or any other standard include path, so compilation of
Src/Modules/pcre.c fails unless I change the

  #include <pcre.h>

to
 
  #include <pcre/pcre.h>

Obviously this needs a more general fix, but I'm not sure how to do
it.

RE: location of pcre.h

[Borsenkow Andrej]

>
> On my RedHat 7.0 system, pcre.h is in /usr/include/pcre, not
> /usr/include or any other standard include path, so compilation of
> Src/Modules/pcre.c fails unless I change the
>
>   #include <pcre.h>
>
> to
>
>   #include <pcre/pcre.h>
>
> Obviously this needs a more general fix, but I'm not sure how to do
> it.
>

Do they have anything else in /usr/include/pcre? Else I'd call this broken
(yet another thing in 7.0).


Obvious fix is to check for both pcre.h and pcre/pcre.h and take whatever
exists

#ifdef HAVE_PCRE_H
#include <pcre.h>
#else
#ifdef HAVE_PCRE_PCRE_H - ick!
#include <pcre/pcre.h>
#else
#error pcre not found
#endif
#endif

Additionally, pcre should be compiled conditionally only if prerequisites
are found (compare termcap.mdd or terminfo.mdd).

-andrej

Re: location of pcre.h

[Adam Spiers]

Borsenkow Andrej (Andrej.Borsenkow@mow.siemens.ru) wrote:
> Do they have anything else in /usr/include/pcre? Else I'd call this broken
> (yet another thing in 7.0).

Yes, pcreposix.h is also there.

> Obvious fix is to check for both pcre.h and pcre/pcre.h and take whatever
> exists
> 
> #ifdef HAVE_PCRE_H
> #include <pcre.h>
> #else
> #ifdef HAVE_PCRE_PCRE_H - ick!
> #include <pcre/pcre.h>
> #else
> #error pcre not found
> #endif
> #endif

Yep.  Presumably this needs some autoconf wizardry to set
HAVE_PCRE_PCRE_H in the first place, which is where I get lost ...

> Additionally, pcre should be compiled conditionally only if prerequisites
> are found (compare termcap.mdd or terminfo.mdd).

There must be a bug in that too then, because I get

  checking for pcre.h... no

Re: location of pcre.h

[Clint Adams]

> Yes, pcreposix.h is also there.
> 
> Yep.  Presumably this needs some autoconf wizardry to set
> HAVE_PCRE_PCRE_H in the first place, which is where I get lost ...

What does `pcre-config --cflags` return?

Re: location of pcre.h

[Adam Spiers]

Clint Adams (clint@zsh.org) wrote:
> > Yes, pcreposix.h is also there.
> > 
> > Yep.  Presumably this needs some autoconf wizardry to set
> > HAVE_PCRE_PCRE_H in the first place, which is where I get lost ...
> 
> What does `pcre-config --cflags` return?

-I/usr/include/pcre

The relevant bit of config.log:

  configure:2692:18: pcre.h: No such file or directory
  configure: failed program was:
  #line 2691 "configure"
  #include "confdefs.h"
  #include <pcre.h>

Re: location of pcre.h

[Clint Adams]

> -I/usr/include/pcre
> 
> The relevant bit of config.log:

The implication is that one is meant to
#include <pcre.h>, not <pcre/pcre.h>;
of course, adding -I/usr/include/pcre
to the build-wide CFLAGS is ugly.

Probably configure should run
pcre-config and then store
the result for reference by
pcre.mdd, when that's possible.

Re: location of pcre.h

[Adam Spiers]

Clint Adams (clint@zsh.org) wrote:
> The implication is that one is meant to #include <pcre.h>, not
> <pcre/pcre.h>; of course, adding -I/usr/include/pcre to the
> build-wide CFLAGS is ugly.

Agreed.

> Probably configure should run pcre-config and then store the result
> for reference by pcre.mdd, when that's possible.

Yep, that sounds good.  Any takers?  I know nothing about autoconf,
and have no time at present to learn :-(

Re: location of pcre.h

[Borsenkow Andrej]

Adam Spiers wrote:

> Borsenkow Andrej (Andrej.Borsenkow@mow.siemens.ru) wrote:
> 
>>Do they have anything else in /usr/include/pcre? Else I'd call this broken
>>(yet another thing in 7.0).
>>
> 
> Yes, pcreposix.h is also there.
> 
> 
>>Obvious fix is to check for both pcre.h and pcre/pcre.h and take whatever
>>exists
>>
>>#ifdef HAVE_PCRE_H
>>#include <pcre.h>
>>#else
>>#ifdef HAVE_PCRE_PCRE_H - ick!
>>#include <pcre/pcre.h>
>>#else
>>#error pcre not found
>>#endif
>>#endif
>>
> 
> Yep.  Presumably this needs some autoconf wizardry to set
> HAVE_PCRE_PCRE_H in the first place, which is where I get lost ...
> 


Just add it to AC_CHECK_HEADERS(...), near pcre.h.


> 
>>Additionally, pcre should be compiled conditionally only if prerequisites
>>are found (compare termcap.mdd or terminfo.mdd).
>>
> 
> There must be a bug in that too then, because I get
> 
>   checking for pcre.h... no
> 
> 


There is probably no bug. I meant "we should add code to pcre.mdd to 
conditionally compile it", not that it is already there. Currently it is 
unconditional.

Ideally, it would be nice to have some high level means to specify 
conditions ... probably something like

need_headers="pcre.h"
need_libraries="perl.so"

or like. It is better to no add any autoconf-dependent code to mdd files.

-andrej