From: Sven Wischnowsky <wischnow@informatik.hu-berlin.de>
To: zsh-workers@sunsite.dk
Subject: Re: A few compiler warnings
Date: Wed, 8 Aug 2001 09:26:18 +0200 (MET DST) [thread overview]
Message-ID: <200108080726.JAA04377@beta.informatik.hu-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0108071641480.18512-100000@phong.blorf.net>
Wayne Davison wrote:
> The following patch silences a few compiler warnings.
I'm terribly sorry -- compiling with optimisation is so slow that I
normally don't do it (only once in a while and before releases) and
without optimisations gcc doesn't report things like these.
> The first hunk sets "n" to NULL in bld_parts(). This isn't required
> by the code, but gcc isn't smart enough to figure out that "n" can't
> be used uninitialized.
Yep.
> The second hunk removes 3 unused variables.
Hmhm, the improved calculation.
> The third hunk silences 3 "might be used uninitialized" warnings, but
> someone who knows the code in cd_get() should look at it and see if
> there is a better fix (such as making one of the other switch-case
> sections the "default:", or returning an error).
Yes, run->type can only ever be of one of the CRT_* values, so we could
alternatively just turn any of the other `case's into `default'.
> I haven't committed any of this yet, though the second hunk is really
> a no-brainer. Comments?
Please go ahead and commit it.
Thanks!
Bye
Sven
--
Sven Wischnowsky wischnow@informatik.hu-berlin.de
prev parent reply other threads:[~2001-08-08 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-07 23:51 Wayne Davison
2001-08-08 7:26 ` Sven Wischnowsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108080726.JAA04377@beta.informatik.hu-berlin.de \
--to=wischnow@informatik.hu-berlin.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).