zsh-workers
 help / color / mirror / code / Atom feed
From: Stefan Dalibor <dalibor@caldera.de>
To: zsh-workers@sunsite.dk
Subject: Buglette & Fix for checkrmall in 4.0.2
Date: Mon, 15 Oct 2001 13:32:42 +0200	[thread overview]
Message-ID: <20011015133242.A2458@caldera.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Hi,
just in case nobody else has been stumbled into this: 4.0.2 segfaults
in checkrmall() (under OpenLinux 3.1, i.e. Linux 2.4.* with glibc 2.2.1
and 2.2.4) when executing the following function:

function www {
	typeset netscapefiles="{lock,plugin-list*,history*,*cache/*,archive/*,*.db,abook.nab,registry,summary*,custom.dic}" \
		nsmaildir=$HOME/nsmail
	(	
		if [ -z "$DISPLAY" -a "$KPSYSTYPE" = 'i86linux' ]; then
			# Fire up X and start Mozilla from Linux text console:
			startx netscape "$@"
		else
			netscape "$@"
		fi
		# This crashes zsh-4.0.2 if unpatched:
		eval command rm -fr $HOME/.netscape/$netscapefiles /tmp/ndebug
		[ -d $nsmaildir ] && rmdir $nsmaildir
	) &
}

This is due to checkrmall() calling fprintf() with a NULL file ptr in
shout.

Please find attached the dumbest possible patch... it prevents the crash,
but I didn't investigate on wether it is the appropriate place for a
fix (should Zsh recognize that it's useless to call checkrmall() when
running in the background in the first place?  Is the NULL file ptr a
bug in itself?).

Cheers,
Stefan

P.S.: If you have any further questions, please set me on CC (I'm only on
      the Zsh announce list)
--
Dr.Ing. Stefan Dalibor <scd@caldera.de>

[-- Attachment #2: zsh-4.0.2-nostderrfix.patch --]
[-- Type: application/x-patch, Size: 384 bytes --]

             reply	other threads:[~2001-10-15 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-15 11:32 Stefan Dalibor [this message]
2001-10-15 16:53 ` Bart Schaefer
2001-10-15 17:07   ` Peter Stephenson
2001-10-15 18:13     ` Borsenkow Andrej
2001-10-15 19:30       ` Bart Schaefer
2001-10-15 17:03 ` Bart Schaefer
2001-10-20 17:48 ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011015133242.A2458@caldera.de \
    --to=dalibor@caldera.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).