From: Clint Adams <clint@zsh.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@sunsite.dk, david@debian.org
Subject: Re: PATCH: _ssh (scp)
Date: Mon, 4 Feb 2002 13:43:15 -0500 [thread overview]
Message-ID: <20020204184315.GA14218@dman.com> (raw)
In-Reply-To: <1020204182501.ZM21407@candle.brasslantern.com>
> This still needs the 2>/dev/null fix I described in 16533.
Right. Patch below. Also adds | to the bracket expression.
We still need a solution to the zle redisplay problem.
> If you *are* going to parse "ls -F" output, you should remove the comment
> that indicates otherwise.
Well, it's not doing colorings, but I'll modify the comment.
> Another possible approach would be to use ls (without -d) on the directory
> parent of the remote path, and let the completion system filter out the
> non-matching names, rather than the rather crude hack I did of appending
> a `*' to the path. This would support complete-in-word a bit better, but
> means more network traffic.
That should probably be configurable via an adjunct to the remote-access
style then.
Index: Completion/Unix/Command/_ssh
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_ssh,v
retrieving revision 1.6
diff -u -r1.6 _ssh
--- Completion/Unix/Command/_ssh 2002/02/04 18:03:25 1.6
+++ Completion/Unix/Command/_ssh 2002/02/04 18:40:48
@@ -1,15 +1,15 @@
#compdef ssh slogin=ssh scp ssh-add ssh-agent ssh-keygen
_remote_files () {
- # This is extremely simple-minded; could parse "ls -F" output to do
- # colorings and LIST_TYPES and so on, but I'm just not that ambitious.
+ # Rather than simple directory discrimination, there should be
+ # coloring based on all the different ls -F classifiers.
local expl remfiles
if zstyle -T ":completion:${curcontext}:" remote-access; then
- remfiles=(${(f)"$(ssh -a -x ${words[CURRENT]%:*} ls -d1F ${words[CURRENT]#*:}\*)"})
+ remfiles=(${(f)"$(ssh -a -x ${words[CURRENT]%:*} ls -d1F ${words[CURRENT]#*:}\* 2>/dev/null)"})
_wanted files expl 'remote files' \
- compadd ${${remfiles:#*/}/[*=@](#e)/}
+ compadd ${${remfiles:#*/}/[*=@|](#e)/}
_wanted dirs expl 'remote directories' \
compadd -S/ ${${(M)remfiles:#*/}/\\/(#e)/}
next prev parent reply other threads:[~2002-02-04 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-04 17:59 Clint Adams
2002-02-04 18:25 ` Bart Schaefer
2002-02-04 18:43 ` Clint Adams [this message]
2002-02-05 10:24 ` Oliver Kiddle
2002-02-05 17:47 ` Clint Adams
2002-02-05 18:08 ` Clint Adams
2002-02-05 18:38 ` Bart Schaefer
2002-02-06 16:43 ` Clint Adams
2002-02-06 16:59 ` Borsenkow Andrej
2002-02-06 18:12 ` The :h modifier Brass Lantern Enterprises
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020204184315.GA14218@dman.com \
--to=clint@zsh.org \
--cc=david@debian.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).