From: Zefram <zefram@fysh.org>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: Re: zsh: can't find terminal definition on vt100
Date: Tue, 12 Feb 2002 17:16:20 +0000 [thread overview]
Message-ID: <20020212171620.GC17816@fysh.org> (raw)
In-Reply-To: <1020212165549.ZM15901@candle.brasslantern.com>
Bart Schaefer wrote:
>--- Src/init.c 2001/10/22 17:03:58 1.7
>+++ Src/init.c 2002/02/12 16:40:47
>@@ -535,11 +535,15 @@
>
> #ifdef TGETENT_ACCEPTS_NULL
> /* If possible, we let tgetent allocate its own termcap buffer */
>- if (tgetent(NULL, term) != 1) {
>+# ifdef TGETENT_ZERO_SUCCESS
>+ if (tgetent(NULL, term) != 0)
>+# else
>+ if (tgetent(NULL, term) != 1)
>+# endif
> #else
>- if (tgetent(termbuf, term) != 1) {
>+ if (tgetent(termbuf, term) != 1)
> #endif
>-
>+ {
Surely these two conditions are orthogonal -- your configure tests are
orthogonal -- so we really want code like
if (
#ifdef TGETENT_ACCEPTS_NULL
tgetent(NULL, term)
#else
tgetent(termbuf, term)
#endif
#ifdef TGETENT_ZERO_SUCCESS
!= 0
#else
!= 1
#endif
) {
Or, of course, make it clearer by defining macros for TGETENT_SUCCESS etc.
-zefram
next prev parent reply other threads:[~2002-02-12 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-05 19:01 rangarao.ragavendran
2002-02-12 16:55 ` PATCH: " Bart Schaefer
2002-02-12 17:16 ` Zefram [this message]
2002-02-12 17:40 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020212171620.GC17816@fysh.org \
--to=zefram@fysh.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).