* Today's TCP Fix (TM) (4)
@ 2002-06-05 20:55 Peter Stephenson
2002-06-05 21:06 ` Bart Schaefer
0 siblings, 1 reply; 2+ messages in thread
From: Peter Stephenson @ 2002-06-05 20:55 UTC (permalink / raw)
To: Zsh hackers list
Today's Fix is in two parts: first, fix the problem that if a user
closed a connection you couldn't get rid of the session. I don't see
any alternative to simply deleting the session even if the close failed.
Second, if you unloaded the tcp module it didn't delete ztcp from the
builtin table, which was liable to cause a crash the next time the table
was scanned.
Index: Src/Modules/tcp.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v
retrieving revision 1.31
diff -u -r1.31 tcp.c
--- Src/Modules/tcp.c 30 May 2002 15:16:21 -0000 1.31
+++ Src/Modules/tcp.c 5 Jun 2002 20:52:31 -0000
@@ -299,10 +299,7 @@
{
err = close(sess->fd);
if (err)
- {
zwarn("connection close failed: %e", NULL, errno);
- return -1;
- }
}
zts_delete(sess);
return 0;
@@ -701,6 +698,7 @@
cleanup_(Module m)
{
tcp_cleanup();
+ deletebuiltins(m->nam, bintab, sizeof(bintab)/sizeof(*bintab));
freelinklist(ztcp_sessions, (FreeFunc) ztcp_free_session);
return 0;
}
--
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Today's TCP Fix (TM) (4)
2002-06-05 20:55 Today's TCP Fix (TM) (4) Peter Stephenson
@ 2002-06-05 21:06 ` Bart Schaefer
0 siblings, 0 replies; 2+ messages in thread
From: Bart Schaefer @ 2002-06-05 21:06 UTC (permalink / raw)
To: Peter Stephenson; +Cc: Zsh hackers list
On Wed, 5 Jun 2002, Peter Stephenson wrote:
> Today's Fix is in two parts: first, fix the problem that if a user
> closed a connection you couldn't get rid of the session. I don't see
> any alternative to simply deleting the session even if the close failed.
You could discard the session only on some subset of possible errors, but
it's probably not worth the effort.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-06-05 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-05 20:55 Today's TCP Fix (TM) (4) Peter Stephenson
2002-06-05 21:06 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).