* Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning [not found] <87el5knkal.fsf@yiwaz.raw.no> @ 2003-03-10 4:42 ` Clint Adams 2004-08-08 5:21 ` Clint Adams 0 siblings, 1 reply; 5+ messages in thread From: Clint Adams @ 2003-03-10 4:42 UTC (permalink / raw) To: zsh-workers; +Cc: Tollef Fog Heen, 183730-forwarded Maybe there should be a truncation warning. 1% SAVEHIST=899795648511 2% print $SAVEHIST 2147483647 3% SAVEHIST=899795648512 4% print $SAVEHIST 0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning 2003-03-10 4:42 ` Bug#183730: zsh: setting SAVEHIST breaks history saving without warning Clint Adams @ 2004-08-08 5:21 ` Clint Adams 2004-08-09 9:50 ` Peter Stephenson 0 siblings, 1 reply; 5+ messages in thread From: Clint Adams @ 2004-08-08 5:21 UTC (permalink / raw) To: zsh-workers; +Cc: 183730 > Maybe there should be a truncation warning. > > 1% SAVEHIST=899795648511 > 2% print $SAVEHIST > 2147483647 > 3% SAVEHIST=899795648512 > 4% print $SAVEHIST Or an error? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning 2004-08-08 5:21 ` Clint Adams @ 2004-08-09 9:50 ` Peter Stephenson 2004-08-09 15:07 ` Clint Adams 0 siblings, 1 reply; 5+ messages in thread From: Peter Stephenson @ 2004-08-09 9:50 UTC (permalink / raw) To: zsh-workers, 183730 Clint Adams wrote: > > Maybe there should be a truncation warning. > > > > 1% SAVEHIST=899795648511 > > 2% print $SAVEHIST > > 2147483647 > > 3% SAVEHIST=899795648512 > > 4% print $SAVEHIST > > Or an error? (Why does this `break history saving'? Or is the subject line inaccurate? I'll assume the latter for now.) I suspect there could be a lot of problems like this. History numbering ought to wrap gracefully, but I expect it doesn't. Also, arithmetic is done as a `zlong' which is probably 64 bits if the compiler supports it, while the history size and many other parameters are only 32 bits. Consequently there are lots of place which would need to change to make this sort of thing consistent, - the history code itself - where integers from arithmetic expresssions are assigned to variables (though maybe it would be more consistent to use zlong for parameters set by the user) - where numbers are originally parsed. The number assigned is obviously too large to be directly useful; what was the intention? Always save values at the end of the history list regardless of what was there already? -- Peter Stephenson <pws@csr.com> Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com ********************************************************************** ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning 2004-08-09 9:50 ` Peter Stephenson @ 2004-08-09 15:07 ` Clint Adams 2004-08-09 15:14 ` Peter Stephenson 0 siblings, 1 reply; 5+ messages in thread From: Clint Adams @ 2004-08-09 15:07 UTC (permalink / raw) To: Peter Stephenson; +Cc: zsh-workers, 183730-submitter > (Why does this `break history saving'? Or is the subject line > inaccurate? I'll assume the latter for now.) I think he set SAVEHIST to some enormously large value which wrapped to 0, and thus the saving of his history was "broken", without a clear indication why. > The number assigned is obviously too large to be directly useful; what > was the intention? Always save values at the end of the history list > regardless of what was there already? Perhaps. Tollef, could you elaborate? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning 2004-08-09 15:07 ` Clint Adams @ 2004-08-09 15:14 ` Peter Stephenson 0 siblings, 0 replies; 5+ messages in thread From: Peter Stephenson @ 2004-08-09 15:14 UTC (permalink / raw) To: zsh-workers, 183730-submitter Clint Adams wrote: > > (Why does this `break history saving'? Or is the subject line > > inaccurate? I'll assume the latter for now.) > > I think he set SAVEHIST to some enormously large value which wrapped to > 0, and thus the saving of his history was "broken", without a clear > indication why. What could happen is the value when converted to int appeared negative --- that would cause it to be set to zero. More care with casts and conversions ought to fix that. -- Peter Stephenson <pws@csr.com> Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com ********************************************************************** ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-08-09 15:16 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <87el5knkal.fsf@yiwaz.raw.no> 2003-03-10 4:42 ` Bug#183730: zsh: setting SAVEHIST breaks history saving without warning Clint Adams 2004-08-08 5:21 ` Clint Adams 2004-08-09 9:50 ` Peter Stephenson 2004-08-09 15:07 ` Clint Adams 2004-08-09 15:14 ` Peter Stephenson
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).