Another crash bug in "print"

Another crash bug in "print"

[Bart Schaefer]

I just stumbled upon this in zsh 3.0.7, but it's still there in 4.1.0-dev7
(latest CVS):

zagzig% print -m
zsh: segmentation fault (core dumped)  Src/zsh -f

#0  0x806b0b3 in zshtokenize (s=0x0, shglob=0) at ../../zsh-4.0/Src/glob.c:2469
2469        for (; *s; s++) {
(gdb) where
#0  0x806b0b3 in zshtokenize (s=0x0, shglob=0) at ../../zsh-4.0/Src/glob.c:2469
#1  0x806b07e in tokenize (s=0x0) at ../../zsh-4.0/Src/glob.c:2452
#2  0x80542e6 in bin_print (name=0x40015178 "print", args=0xbffff41c, 
    ops=0xbffff448, func=13) at ../../zsh-4.0/Src/builtin.c:3115

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: Another crash bug in "print"

[Wayne Davison]

On Fri, Mar 28, 2003 at 05:35:10PM +0000, Bart Schaefer wrote:
> zagzig% print -m
> zsh: segmentation fault (core dumped)  Src/zsh -f

This looks like the right fix to me:

Index: Src/builtin.c
--- Src/builtin.c	17 Feb 2003 10:08:03 -0000	1.97
+++ Src/builtin.c	28 Mar 2003 18:21:25 -0000
@@ -3111,7 +3111,11 @@
     if (OPT_ISSET(ops,'m')) {
 	Patprog pprog;
 	char **t, **p;
-	
+
+	if (!*args) {
+	    zwarnnam(name, "no pattern specified", NULL, 0);
+	    return 1;
+	}
 	tokenize(*args);
 	if (!(pprog = patcompile(*args, PAT_STATIC, NULL))) {
 	    untokenize(*args);

..wayne..