From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.dk
Subject: Re: Conflict with zftp + tcp modules?
Date: Wed, 23 Apr 2003 18:47:43 +0100 [thread overview]
Message-ID: <20030423174748.ED31A1B76A@pwstephenson.fsnet.co.uk> (raw)
In-Reply-To: "Borzenkov Andrey"'s message of "Mon, 21 Apr 2003 15:49:50 +0400." <6134254DE87BD411908B00A0C99B044F03A0B6C3@mowd019a.mow.siemens.ru>
Borzenkov Andrey wrote:
> it was never intended to work this way. Zftp.c includes zftp.mdh and tcp.h
> that in turn includes tcp.mdh. mdh is expected to _the_ only and single mdh
> for the module being compiled; having two mdh's is wrong.
>
> Oliver, Peter, could you look in tcp and see if you can move tcp.mdh =
> into
> tcp.c?
Seems to be trivial, at least it doesn't generate any new errors or
warnings here.
Index: Src/Modules/tcp.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v
retrieving revision 1.34
diff -u -r1.34 tcp.c
--- Src/Modules/tcp.c 6 Feb 2003 12:21:49 -0000 1.34
+++ Src/Modules/tcp.c 23 Apr 2003 18:37:06 -0000
@@ -34,6 +34,7 @@
* doesn't exist on cygwin.
*/
#include "tcp.h"
+#include "tcp.mdh"
/*
* We use poll() in preference to select because some subset of manuals says
Index: Src/Modules/tcp.h
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.h,v
retrieving revision 1.6
diff -u -r1.6 tcp.h
--- Src/Modules/tcp.h 2 Oct 2001 02:35:01 -0000 1.6
+++ Src/Modules/tcp.h 23 Apr 2003 18:37:06 -0000
@@ -83,7 +83,6 @@
int flags;
};
-#include "tcp.mdh"
#include "tcp.pro"
#ifndef INET_ADDRSTRLEN
--
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk
prev parent reply other threads:[~2003-04-23 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-15 21:59 Bart Schaefer
2003-04-21 11:49 ` Borzenkov Andrey
2003-04-23 17:47 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030423174748.ED31A1B76A@pwstephenson.fsnet.co.uk \
--to=pws@pwstephenson.fsnet.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).