Segmentation fault caused by completion system

Segmentation fault caused by completion system

[Haakon Riiser]

"*" in front of "-+" or "+-" in the optspecs to "_arguments"
causes a segmentation fault on completion.  Here's an example:

  #compdef foo
  _arguments '*-+bar'

Now try using it:

  % foo <TAB>
  foo zsh: segmentation fault (core dumped)  zsh

System info:

  zsh 4.0.6 (i386-slackware-linux-gnu)
  Slackware 9.0 (gcc 3.2.2, termcap 2.0.8, libc 2.3.1)

(I have not subscribed to the mailing list, so if you need anything
else from me, please Cc my private email address.)

-- 
 Haakon

Re: Segmentation fault caused by completion system

[Peter Stephenson]

"Haakon Riiser" wrote:
> "*" in front of "-+" or "+-" in the optspecs to "_arguments"
> causes a segmentation fault on completion.

This appears to be a trivial fix.

Index: Src/Zle/computil.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/computil.c,v
retrieving revision 1.83
diff -u -r1.83 computil.c
--- Src/Zle/computil.c	27 Aug 2002 21:10:34 -0000	1.83
+++ Src/Zle/computil.c	23 Apr 2003 18:43:45 -0000
@@ -1397,7 +1397,7 @@
 		    opt->descr = NULL;
 	    } else
 		opt->descr = NULL;
-	    opt->xor = (again == 1 ? zarrdup(xor) : xor);
+	    opt->xor = (again == 1 && xor ? zarrdup(xor) : xor);
 	    opt->type = otype;
 	    opt->args = oargs;
 	    opt->num = nopts++;

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk