From: Wayne Davison <wayned@users.sourceforge.net>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: zsh-workers@sunsite.dk
Subject: Re: PATCH: fix menu completion on terminal with do=^J/without do
Date: Wed, 30 Apr 2003 08:55:25 -0700 [thread overview]
Message-ID: <20030430155525.GA5843@binome.blorf.net> (raw)
In-Reply-To: <200304271249.49111.arvidjaar@mail.ru>
On Sun, Apr 27, 2003 at 12:49:49PM +0400, Andrey Borzenkov wrote:
> The patch exports tc_downcurs and makes complist using it.
Yes, this seems to be the right thing to do. Because the init_term()
code may have completely disabled all known downward-motion capabilities
(when it removed "do=^J"), zsh must always call tc_downcurs(ct) instead
of trying to call tcmultout(TCDOWN, TCMULTDOWN, ct) directly. It must
also be prepared to handle a non-zero return code which indicates that
the cursor has moved to column 0.
In the case of your patch, it appears that the calling code always
returns the cursor to column 0 before calling tc_downcurs(), so I
believe your patch to be the right fix.
..wayne..
prev parent reply other threads:[~2003-04-30 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-27 8:49 Andrey Borzenkov
2003-04-27 10:27 ` Geoff Wing
2003-04-30 15:55 ` Wayne Davison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030430155525.GA5843@binome.blorf.net \
--to=wayned@users.sourceforge.net \
--cc=arvidjaar@mail.ru \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).