zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: jobs not listing all commands
Date: Wed, 18 Feb 2004 22:02:28 +0000	[thread overview]
Message-ID: <20040218220230.52447865B@pwstephenson.fsnet.co.uk> (raw)
In-Reply-To: "Bart Schaefer"'s message of "Wed, 18 Feb 2004 17:47:08 GMT." <1040218174708.ZM13219@candle.brasslantern.com>

Bart Schaefer wrote:
> } I'm not sure how to test for this.  Maybe it would be enough to try
> } compiling and linking a programme with grantpt etc., since I think
> } configure is sensitive to compiler warnings.
> 
> While a missing-header test is probably appropriate, in this case I think
> the issue is whether zsh wants to define _XOPEN_SOURCE, and if not, then
> it shouldn't use /dev/ptmx even when the device exists.

Some more results...

1. Defining _GNU_SOURCE seems to work OK, except there is a function
which clashes with the getline in zle_hist.c.  However, that function
doesn't seem to be used anyway.

2. That doesn't fix the problem.  It seems that the problem is the
streams modules --- I was too optimistic about them not causing problems
if they weren't needed.  We need to find out where they are needed.
I'm tempted just to limit that chunk of code to Solaris.  Does anyone
know of another system (with /dev/ptmx) which is keen on ttcompat and
friends?

One course of action:

- Define _GNU_SOURCE for Linux only --- we've got enough testers to make
it fairly painless to find out if this causes compilation problems.
(Defining _XOPEN_SOURCE directly is harder since you've got to work
out the version number.)
- Check for the function definitions, particularly ptsname(), to make
sure.
- Only let the streams stuff cause havoc on Solaris.

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk


  reply	other threads:[~2004-02-18 22:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-17  7:58 Felix Rosencrantz
2004-02-17 10:41 ` Peter Stephenson
2004-02-17 22:14 ` Bart Schaefer
2004-02-18  0:25   ` James Devenish
2004-02-18  0:41     ` Wayne Davison
2004-02-18  6:02     ` Bart Schaefer
2004-02-18 10:24   ` Peter Stephenson
2004-02-18 17:47     ` Bart Schaefer
2004-02-18 22:02       ` Peter Stephenson [this message]
2004-02-20 15:21         ` PATCH: ptmx part 2 Peter Stephenson
2004-02-19 15:22   ` jobs not listing all commands Felix Rosencrantz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040218220230.52447865B@pwstephenson.fsnet.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).