zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk, 175467@bugs.debian.org
Subject: Re: zsh -n and modules
Date: Thu, 11 Mar 2004 11:31:21 -0500	[thread overview]
Message-ID: <20040311163121.GA30575@scowler.net> (raw)
In-Reply-To: <1030106020240.ZM4262@candle.brasslantern.com>

> OK, so the problem is that `zsh -n' is executing math expressions.  It
> should probably treat math expressions just like any other builtin or
> command when the -n option is present; that is, do not execute them.

Is this the right place to fix this?

Index: Src/subst.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/subst.c,v
retrieving revision 1.36
diff -u -r1.36 subst.c
--- Src/subst.c	30 Aug 2003 19:12:18 -0000	1.36
+++ Src/subst.c	11 Mar 2004 16:20:38 -0000
@@ -168,7 +168,11 @@
 	    if (endchar == Outpar && str2[1] == '(' && str[-2] == ')') {
 		/* Math substitution of the form $((...)) */
 		str[-2] = '\0';
-		str = arithsubst(str2 + 2, &str3, str);
+		if (isset(EXECOPT)) {
+		    str = arithsubst(str2 + 2, &str3, str);
+		} else {
+		    strncpy(str3, str2, 1);
+		}
 		setdata(node, (void *) str3);
 		continue;
 	    }


  reply	other threads:[~2004-03-11 16:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-05 20:13 Clint Adams
2003-01-05 22:35 ` Bart Schaefer
2003-01-06  0:19   ` Clint Adams
2003-01-06  2:02     ` Bart Schaefer
2004-03-11 16:31       ` Clint Adams [this message]
2004-03-14 16:24         ` Peter Stephenson
2004-03-14 18:17           ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040311163121.GA30575@scowler.net \
    --to=clint@zsh.org \
    --cc=175467@bugs.debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).