zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: vux/vuxctl completion
Date: Fri, 12 Mar 2004 10:24:43 -0500	[thread overview]
Message-ID: <20040312152443.GA32384@scowler.net> (raw)
In-Reply-To: <29555.1079085603@trentino.logica.co.uk>

> Sorry to winge about this but could we please have consistency on
> indentation across completion functions. Convention is for two spaces.

> Those actions could really do with descriptions:
>   '...:((p\:description g\:...))'
> works.

> This should really have an _wanted before it. We should never be adding
> matches without some sort of description.

Index: Completion/Unix/Command/_vux
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_vux,v
retrieving revision 1.1
diff -u -r1.1 _vux
--- Completion/Unix/Command/_vux	11 Mar 2004 21:29:49 -0000	1.1
+++ Completion/Unix/Command/_vux	12 Mar 2004 15:13:59 -0000
@@ -1,10 +1,15 @@
 #compdef vux vuxctl
 
+local expl
+
 case "$service" in
-	(vux)
+  (vux)
 
-_arguments -s -C \
-	'-x:action:(p g m w r f)' \
+  _arguments -s -C \
+	'-x:action:((play\:play\ music generate\:generate\ new\ scorelist
+	            merge\:merge\ new\ songs
+		    weed\:prune\ songs\ from\ scorelist
+		    ratings\:show\ statistics force\:force-rate))' \
 	'-s:file:_files' \
 	'-a:file:_files' \
 	'-z:file:_files' \
@@ -47,14 +52,13 @@
 	'-P[Always play new songs]' \
 	'-g[print stats in xgraph format]' \
 	'-h[Show summary of options]'
+  ;;
 
-	;;
-
-	(vuxctl)
-
-	compadd start clean double half up down next previous forward \
-		replay pause resume stop reload save history help
+  (vuxctl)
 
-	;;
+  _wanted vuxcmd expl 'vux control command' \
+      compadd start clean double half up down next previous forward \
+	      replay pause resume stop reload save history help
+  ;;
 
 esac


  reply	other threads:[~2004-03-12 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-11 21:35 Clint Adams
2004-03-12 10:00 ` Oliver Kiddle
2004-03-12 15:24   ` Clint Adams [this message]
2004-03-12 15:42   ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040312152443.GA32384@scowler.net \
    --to=clint@zsh.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).