PATCH: tla completion

PATCH: tla completion

[Clint Adams]

This is primitive completion for tla.

Index: Completion/Unix/Command/_tla
===================================================================
RCS file: Completion/Unix/Command/_tla
diff -N Completion/Unix/Command/_tla
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ Completion/Unix/Command/_tla	11 Mar 2004 15:39:00 -0000
@@ -0,0 +1,9 @@
+#compdef tla
+
+subcmds=(${${${(M)${(f)"$(_call_program tla tla help)"}:#[ 	]* : *}% : *}##[ 	]##} )
+
+if (( CURRENT == 2 )); then
+     _describe -t commands 'tla command' compadd - "$subcmds[@]"
+else
+     _files
+fi

Re: PATCH: tla completion

[Jason McCarty]

Clint Adams wrote:
> This is primitive completion for tla.

Please take a look at my tla completion at
http://www.people.iup.edu/bclg/zsh-completion--tla-1.1.tar.gz . It's
probably horrendous from a Z-Shell expert's point of view, and it's for
tla 1.1, but it is pretty complete and offers completion for most tla
arguments, including archive and library revisions, configs, and
patch-logs.

-- 
Jason McCarty <bclg@iup.edu>

Re: PATCH: tla completion

[Clint Adams]

> Please take a look at my tla completion at
> http://www.people.iup.edu/bclg/zsh-completion--tla-1.1.tar.gz . It's
> probably horrendous from a Z-Shell expert's point of view, and it's for
> tla 1.1, but it is pretty complete and offers completion for most tla
> arguments, including archive and library revisions, configs, and
> patch-logs.

Wow, that's a bit longer than mine.  Which parts of the completion
functions are copyrighted by Tom Lord?

Are you going to do an update for tla 1.2?

Re: PATCH: tla completion

[Jason McCarty]

Clint Adams wrote:
> > Please take a look at my tla completion at
> > http://www.people.iup.edu/bclg/zsh-completion--tla-1.1.tar.gz . It's
> > probably horrendous from a Z-Shell expert's point of view, and it's for
> > tla 1.1, but it is pretty complete and offers completion for most tla
> > arguments, including archive and library revisions, configs, and
> > patch-logs.
> 
> Wow, that's a bit longer than mine.  Which parts of the completion
> functions are copyrighted by Tom Lord?

The only things copyrighted by Tom are the option descriptions in
{commands,options}.zsh. I'm not sure they're really copyrightable, but I
gave him credit anyway. He didn't directly contribute anything
otherwise. Most of the functions in completions.zsh have work from Erik
Toubro Nielsen, and some of those in commands.zsh have work from him and
Rob Weir. Looking at my files, I see my attributions are a bit sloppy ;-)

> Are you going to do an update for tla 1.2?

I have no plans to for the time being, simply because the 1.1 version
works pretty well with 1.2. The only changes needed should be to update
the commands which have changed or been added.

-- 
Jason McCarty <bclg@iup.edu>

Re: PATCH: tla completion

[Clint Adams]

> The only things copyrighted by Tom are the option descriptions in
> {commands,options}.zsh. I'm not sure they're really copyrightable, but I
> gave him credit anyway. He didn't directly contribute anything
> otherwise. Most of the functions in completions.zsh have work from Erik
> Toubro Nielsen, and some of those in commands.zsh have work from him and
> Rob Weir. Looking at my files, I see my attributions are a bit sloppy ;-)

If you, Erik, and Rob want to assign copyright to Peter or the Zsh
Development Group or whatever it is we do, we'll clean it up a bit and
include it upstream.

> I have no plans to for the time being, simply because the 1.1 version
> works pretty well with 1.2. The only changes needed should be to update
> the commands which have changed or been added.

Know of anything besides the rm command?

Re: PATCH: tla completion

[Jason McCarty]

Clint Adams wrote:
> > The only things copyrighted by Tom are the option descriptions in
> > {commands,options}.zsh. I'm not sure they're really copyrightable, but I
> > gave him credit anyway. He didn't directly contribute anything
> > otherwise. Most of the functions in completions.zsh have work from Erik
> > Toubro Nielsen, and some of those in commands.zsh have work from him and
> > Rob Weir. Looking at my files, I see my attributions are a bit sloppy ;-)
> 
> If you, Erik, and Rob want to assign copyright to Peter or the Zsh
> Development Group or whatever it is we do, we'll clean it up a bit and
> include it upstream.

I'd be fine with licensing it under Zsh's license (I guess that makes me
part of the Zsh Development Group). I'll ask them about it.

> > I have no plans to for the time being, simply because the 1.1 version
> > works pretty well with 1.2. The only changes needed should be to update
> > the commands which have changed or been added.
> 
> Know of anything besides the rm command?

The commands
  tla delta lord@emf.net--2003b/tla--devo--1.1--patch-286 \
    lord@emf.net--2004/tla--devo--1.3--patch-1 changes
  tla show-changeset changes | grep 'libarch/cmd-.*\.c$'
give a list of the relevant changed files since my last update. However,
many of these are irrelevant changes, which you can determine by
examining the files in changes/patches. It also looks like there are no
new aliases (found in libarch/cmds.c). The changed files are:

  cmd-abrowse.c cmd-add-id.c cmd-add-log-version.c cmd-add-pristine.c
  cmd-ancestry-graph.c cmd-ancestry.c cmd-apply-changeset.c
  cmd-apply-delta.c cmd-archive-fixup.c cmd-archive-meta-info.c
  cmd-archive-mirror.c cmd-archive-setup.c cmd-archive-snapshot.c
  cmd-archive-version.c cmd-archives.c cmd-branches.c cmd-build-config.c
  cmd-cachedrevs.c cmd-cacherev.c cmd-cat-archive-log.c cmd-cat-config.c
  cmd-cat-log.c cmd-categories.c cmd-changelog.c cmd-changes.c
  cmd-changeset.c cmd-commit.c cmd-default-id.c cmd-delete-id.c
  cmd-delta.c cmd-file-diffs.c cmd-file-find.c cmd-find-pristine.c
  cmd-get-changeset.c cmd-get.c cmd-grab.c cmd-help.c
  cmd-id-tagging-defaults.c cmd-id-tagging-method.c cmd-id.c
  cmd-import.c cmd-init-tree.c cmd-inventory.c cmd-join-branch.c
  cmd-library-add.c cmd-library-archives.c cmd-library-branches.c
  cmd-library-categories.c cmd-library-config.c cmd-library-file.c
  cmd-library-find.c cmd-library-log.c cmd-library-remove.c
  cmd-library-revisions.c cmd-library-versions.c cmd-lock-pristine.c
  cmd-lock-revision.c cmd-log-for-merge.c cmd-log-versions.c cmd-logs.c
  cmd-make-archive.c cmd-make-branch.c cmd-make-category.c
  cmd-make-log.c cmd-make-version.c cmd-merges.c cmd-missing.c
  cmd-move-id.c cmd-mv.c cmd-my-default-archive.c cmd-my-id.c
  cmd-my-revision-library.c cmd-new-merges.c cmd-parse-package-name.c
  cmd-pristines.c cmd-rbrowse.c cmd-redo.c cmd-register-archive.c
  cmd-remove-log-version.c cmd-replay.c cmd-revisions.c cmd-rm.c
  cmd-set-tree-version.c cmd-show-changeset.c cmd-star-merge.c
  cmd-sync-tree.c cmd-tag.c cmd-tree-lint.c cmd-tree-root.c
  cmd-tree-version.c cmd-uncacherev.c cmd-undo.c cmd-update.c
  cmd-valid-package-name.c cmd-versions.c cmd-whereis-archive.c

-- 
Jason McCarty <bclg@iup.edu>

Re: PATCH: tla completion

[Peter Stephenson]

Clint Adams wrote:
> If you, Erik, and Rob want to assign copyright to Peter or the Zsh
> Development Group or whatever it is we do, we'll clean it up a bit and
> include it upstream.

We don't tend to assign copyright to anyone else; simply providing it
under the appropriate licen[c/s]e is fine.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************

Re: PATCH: tla completion

[Jason McCarty]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Clint Adams wrote:
[RE my completion for tla]
> If you, Erik, and Rob want to assign copyright to Peter or the Zsh
> Development Group or whatever it is we do, we'll clean it up a bit and
> include it upstream.

OK, we're all willing to relicense under the ZSH license. Emails from
Rob and Erik are attached.

I also had the thought that you could get the options and their
descriptions (but not the syntax) from "tla $command -h", negating the
need to include the help text in the completion itself. But I don't know
when I might have time to implement such a thing.

Thanks for your interest,

Jason McCarty

[-- Attachment #2: Type: message/rfc822, Size: 1762 bytes --]

From: Erik Toubro Nielsen <erik@tntech.dk>
To: Jason McCarty <bclg@iup.edu>
Subject: Re: relicense tla completion for inclusion in zsh upstream?
Date: Fri, 12 Mar 2004 20:37:25 +0100
Message-ID: <m2ad2ldfgq.fsf@upstroke.mdsdenmark.com>

Hi Jason,

Jason McCarty <bclg@iup.edu> writes:

> Hi,
> 
> I've gotten mail from Clint Adams <clint@zsh.org> that he'd like to
> clean up my zsh completion for tla and include it in zsh upstream. To do
> so, I think it needs to be relicensed under zsh's license
> (http://cvs.sourceforge.net/viewcvs.py/zsh/zsh/LICENCE?view=markup).
> Would you both be willing to relicense your contributions that way?

Yes I would.

Erik Toubro Nielsen

> 
> Thanks.
> 
> -- 
> Jason McCarty <bclg@iup.edu>

[-- Attachment #3: Type: message/rfc822, Size: 2793 bytes --]

[-- Attachment #3.1.1: Type: text/plain, Size: 745 bytes --]

On Thu, Mar 11, 2004 at 10:18:58PM -0500, Jason McCarty said
> Hi,
> 
> I've gotten mail from Clint Adams <clint@zsh.org> that he'd like to
> clean up my zsh completion for tla and include it in zsh upstream. To do
> so, I think it needs to be relicensed under zsh's license
> (http://cvs.sourceforge.net/viewcvs.py/zsh/zsh/LICENCE?view=markup).
> Would you both be willing to relicense your contributions that way?

I'd be happy to:

I hearby offer my zsh tla completion work under the same license as zsh
itself, in addition to the GNU GPL, version 2 or later.

-- 
Rob Weir <rweir@ertius.org> | mlspam@ertius.org  |  Do I look like I want a CC?
Words of the day: Rule Psix Juiliett Class Submarine beanpole satellite imagery

[-- Attachment #3.1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: PATCH: tla completion

[Clint Adams]

> OK, we're all willing to relicense under the ZSH license. Emails from
> Rob and Erik are attached.

Okay.

> I also had the thought that you could get the options and their
> descriptions (but not the syntax) from "tla $command -h", negating the
> need to include the help text in the completion itself. But I don't know
> when I might have time to implement such a thing.

You might want to take a look at _subversion for something like that.