From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24249 invoked from network); 13 Apr 2004 02:20:06 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 13 Apr 2004 02:20:06 -0000 Received: (qmail 26237 invoked by alias); 13 Apr 2004 02:20:00 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 19763 Received: (qmail 26188 invoked from network); 13 Apr 2004 02:20:00 -0000 Received: from localhost (HELO sunsite.dk) (127.0.0.1) by localhost with SMTP; 13 Apr 2004 02:20:00 -0000 X-MessageWall-Score: 0 (sunsite.dk) Received: from [130.225.247.86] by sunsite.dk (MessageWall 1.0.8) with SMTP; 13 Apr 2004 2:19:59 -0000 Received: (qmail 31751 invoked from network); 13 Apr 2004 02:19:59 -0000 Received: from acolyte.scowler.net (216.254.112.45) by a.mx.sunsite.dk with SMTP; 13 Apr 2004 02:19:58 -0000 Received: by acolyte.scowler.net (Postfix, from userid 1000) id 421D370047; Mon, 12 Apr 2004 22:19:31 -0400 (EDT) Date: Mon, 12 Apr 2004 22:19:31 -0400 From: Clint Adams To: Jay Berkenbilt Cc: zsh-workers@sunsite.dk, 243385@bugs.debian.org Subject: Re: [ejb@ql.org: Bug#243385: zsh: rsync completion expands * too soon] Message-ID: <20040413021931.GA10355@scowler.net> References: <20040413012117.GA9729@scowler.net> <200404130137.i3D1b5CW004764@soup.in.ql.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200404130137.i3D1b5CW004764@soup.in.ql.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 > Yes. Well, kind of. It's an eval issue. The call to _call_program > (which I have removed) causes the wildcard to be expanded too early > because it calls eval. Here's a trace excerpt. I haven't tried this at all, but maybe this will fix your problem. Index: Completion/Unix/Command/_rsync =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_rsync,v retrieving revision 1.8 diff -u -r1.8 _rsync --- Completion/Unix/Command/_rsync 14 Nov 2003 11:56:55 -0000 1.8 +++ Completion/Unix/Command/_rsync 13 Apr 2004 02:05:03 -0000 @@ -37,8 +37,8 @@ if zstyle -T ":completion:${curcontext}:" remote-access; then slash=/ - remfiles=(${(f)"$(_call_program files ssh -a -x ${words[CURRENT]%:*} ls -d1F ${${${words[CURRENT -]#*:}:h}/${slash}(#e)/}/\* 2>/dev/null)"}) + remfiles=(${(f)"$(_call_program files ssh -a -x ${words[CURRENT]%:*} ls -d1F "${${${words[CURRENT +]#*:}:h}/${slash}(#e)/}/\* 2>/dev/null")"}) remdispf=(${remfiles:#*/}) remdispd=(${(M)remfiles:#*/})