Re: PATCH: (3) - FreeBSD compatability issue resolved

[Vincent Stemen <zsh@hightek.org>]

On Fri, Apr 30, 2004 at 10:26:24PM +0100, Peter Stephenson wrote:
> Patch to apply on top of previous goes to attempt to handle TRAPS_ASYNC
> the way I think is intended.  It's basically an `if' with a
> sigemptyset() inside it, hope no one was expecting anything sophisticated.
> 
> It doesn't fix the behaviour I noted, that without the option any child
> exiting, not just the one the shell is currently expecting, causes traps
> to be run.  Probably that's not a big issue; I should really check the
> wording of POSIX.
> 
> So I think that's it... Vincent?

Just following up with a status report.  I did further testing, running the
FreeBSD boot and shutdown scripts and, so far as I can tell, everything is
working great as a plug in replacement for /bin/sh now.  Nice work!

The only minor thing I noticed is some warnings I get when I compile:

parameter.c: In function `scanpmparameters':
parameter.c:191: warning: dereferencing type-punned pointer will break strict-aliasing rules
parameter.c: In function `scanpmcommands':
parameter.c:330: warning: dereferencing type-punned pointer will break strict-aliasing rules

...etc, etc.


I saw in the list archive, that you discussed this back in February.  I did
not know the status of it so I thought I would mention it in case you were
unaware these warnings were still being produced under FreeBSD.  I am
compiling with gcc-3.2.2.

Thanks again, Peter, for quickly addressing the FreeBSD sh compatibility
signal issue.

Best regards,
Vincent

-- 
Vincent Stemen
Avoid the VeriSign/Network Solutions domain registration trap!
Read how Network Solutions (NSI) was involved in stealing our domain name.
http://www.InetAddresses.net