From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7791 invoked from network); 4 May 2004 07:18:14 -0000 Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (qmailr@130.225.247.86) by ns1.primenet.com.au with SMTP; 4 May 2004 07:18:14 -0000 Received: (qmail 7569 invoked from network); 4 May 2004 07:17:58 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 4 May 2004 07:17:58 -0000 Received: (qmail 23292 invoked by alias); 4 May 2004 07:17:56 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 19870 Received: (qmail 23282 invoked from network); 4 May 2004 07:17:55 -0000 Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (qmailr@130.225.247.86) by sunsite.dk with SMTP; 4 May 2004 07:17:52 -0000 Received: (qmail 7386 invoked from network); 4 May 2004 07:17:52 -0000 Received: from lakermmtao01.cox.net (68.230.240.38) by a.mx.sunsite.dk with SMTP; 4 May 2004 07:17:50 -0000 Received: from quark.hightek.org ([68.12.75.33]) by lakermmtao01.cox.net (InterMail vM.6.01.03.02 201-2131-111-104-20040324) with ESMTP id <20040504071722.CHDJ8483.lakermmtao01.cox.net@quark.hightek.org> for ; Tue, 4 May 2004 03:17:22 -0400 Received: by quark.hightek.org (Postfix, from userid 501) id 77FFD12408; Tue, 4 May 2004 02:17:22 -0500 (CDT) Date: Tue, 4 May 2004 02:17:22 -0500 From: Vincent Stemen To: Zsh hackers list Subject: Re: PATCH: (3) - FreeBSD compatability issue resolved Message-ID: <20040504071722.GA50843@quark.hightek.org> References: <20040422085956.GA69814@quark.hightek.org> <20040430212625.7C6B48551@pwstephenson.fsnet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040430212625.7C6B48551@pwstephenson.fsnet.co.uk> User-Agent: Mutt/1.4.1i X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: * X-Spam-Status: No, hits=1.5 required=6.0 tests=RCVD_IN_SORBS autolearn=no version=2.63 X-Spam-Hits: 1.5 On Fri, Apr 30, 2004 at 10:26:24PM +0100, Peter Stephenson wrote: > Patch to apply on top of previous goes to attempt to handle TRAPS_ASYNC > the way I think is intended. It's basically an `if' with a > sigemptyset() inside it, hope no one was expecting anything sophisticated. > > It doesn't fix the behaviour I noted, that without the option any child > exiting, not just the one the shell is currently expecting, causes traps > to be run. Probably that's not a big issue; I should really check the > wording of POSIX. > > So I think that's it... Vincent? Just following up with a status report. I did further testing, running the FreeBSD boot and shutdown scripts and, so far as I can tell, everything is working great as a plug in replacement for /bin/sh now. Nice work! The only minor thing I noticed is some warnings I get when I compile: parameter.c: In function `scanpmparameters': parameter.c:191: warning: dereferencing type-punned pointer will break strict-aliasing rules parameter.c: In function `scanpmcommands': parameter.c:330: warning: dereferencing type-punned pointer will break strict-aliasing rules ...etc, etc. I saw in the list archive, that you discussed this back in February. I did not know the status of it so I thought I would mention it in case you were unaware these warnings were still being produced under FreeBSD. I am compiling with gcc-3.2.2. Thanks again, Peter, for quickly addressing the FreeBSD sh compatibility signal issue. Best regards, Vincent -- Vincent Stemen Avoid the VeriSign/Network Solutions domain registration trap! Read how Network Solutions (NSI) was involved in stealing our domain name. http://www.InetAddresses.net