From: Clint Adams <clint@zsh.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: 245678-submitter@bugs.debian.org, zsh-workers@sunsite.dk
Subject: Re: Bug#245678: zsh: built-in rm -rf fills up the memory
Date: Sat, 8 May 2004 10:02:07 -0400 [thread overview]
Message-ID: <20040508140207.GA25045@scowler.net> (raw)
In-Reply-To: <20040508043530.GA21396@scowler.net>
> I think I've found the problem. Here's an excerpt from an strace of
> the zsh/files rm -rf going wild. There are 55 or 56 such calls to mmap
> for every length value. Thus it appears that zsh is allocating
> considerably more memory than it needs.
More on this:
recursivecmd_dorec() calls hrealloc() for each target file, incrementing
size accordingly. hrealloc() rounds the new length up to the nearest
page boundary, and mmaps a new Heap for each file.
So, for example, if you have a directory with one hundred files with
9-byte filenames, zsh might allocate one hundred 4096-byte areas. If
you have several thousand files with 70- to 80-byte filenames, zsh
might allocate over 50 4096-byte areas, over 50 8192-byte areas, and so
on.
Now, should this be fixed by making hrealloc() smarter or
recursivecmd_dorec() more efficient?
next prev parent reply other threads:[~2004-05-08 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040424162150.GA4210@ay.vinc17.org>
2004-04-25 1:36 ` Clint Adams
2004-04-25 20:45 ` Bart Schaefer
2004-04-25 21:12 ` Clint Adams
2004-04-25 21:38 ` Clint Adams
2004-04-26 17:10 ` Bart Schaefer
2004-05-08 4:35 ` Clint Adams
2004-05-08 14:02 ` Clint Adams [this message]
2004-05-08 14:13 ` Clint Adams
2004-05-09 22:54 ` Bart Schaefer
2004-05-09 22:48 ` Bart Schaefer
2004-05-09 23:30 ` Clint Adams
2004-05-09 23:36 ` Clint Adams
2004-05-09 23:51 ` Bart Schaefer
2004-05-10 10:16 ` Peter Stephenson
2004-05-10 14:09 ` Clint Adams
2004-05-10 15:54 ` Bart Schaefer
2004-05-10 16:19 ` Peter Stephenson
2004-05-10 16:51 ` Bart Schaefer
2004-05-10 17:23 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040508140207.GA25045@scowler.net \
--to=clint@zsh.org \
--cc=245678-submitter@bugs.debian.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).