From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21521 invoked from network); 8 Jun 2004 21:46:56 -0000 Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.86) by ns1.primenet.com.au with SMTP; 8 Jun 2004 21:46:56 -0000 Received: (qmail 16016 invoked from network); 8 Jun 2004 21:45:56 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 8 Jun 2004 21:45:56 -0000 Received: (qmail 28661 invoked by alias); 8 Jun 2004 21:45:22 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20029 Received: (qmail 28604 invoked from network); 8 Jun 2004 21:45:22 -0000 Received: from thor.dotsrc.org (HELO a.mx.sunsite.dk) (qmailr@130.225.247.86) by sunsite.dk with SMTP; 8 Jun 2004 21:45:19 -0000 Received: (qmail 13765 invoked from network); 8 Jun 2004 21:45:18 -0000 Received: from cmailm3.svr.pol.co.uk (195.92.193.19) by a.mx.sunsite.dk with SMTP; 8 Jun 2004 21:45:16 -0000 Received: from modem-233.bursa-trigger.dialup.pol.co.uk ([62.136.244.233] helo=pwstephenson.fsnet.co.uk) by cmailm3.svr.pol.co.uk with esmtp (Exim 4.14) id 1BXoPD-00081D-R5 for zsh-workers@sunsite.dk; Tue, 08 Jun 2004 22:45:16 +0100 Received: by pwstephenson.fsnet.co.uk (Postfix, from userid 501) id BF35E8652; Tue, 8 Jun 2004 17:51:46 -0400 (EDT) Received: from pwstephenson.fsnet.co.uk (localhost [127.0.0.1]) by pwstephenson.fsnet.co.uk (Postfix) with ESMTP id A92088650 for ; Tue, 8 Jun 2004 22:51:46 +0100 (BST) To: zsh-workers@sunsite.dk (Zsh hackers list) Subject: PATCH: Re: RANDOMSMALL [ ] In-reply-to: "Peter Stephenson"'s message of "Tue, 08 Jun 2004 22:20:09 BST." <20040608212010.5B3F68652@pwstephenson.fsnet.co.uk> Date: Tue, 08 Jun 2004 22:51:45 +0100 From: Peter Stephenson Message-Id: <20040608215146.BF35E8652@pwstephenson.fsnet.co.uk> X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: * X-Spam-Status: No, hits=1.5 required=6.0 tests=BAYES_50,RCVD_IN_SORBS autolearn=no version=2.63 X-Spam-Hits: 1.5 Peter Stephenson wrote: > Look at the math function rand48 in the zsh/mathfunc package. Ooops, this turns out to be badly broken when used with a seed parameter. After the second time you always get the same number. Not actually all that random. Index: Src/Modules/mathfunc.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Modules/mathfunc.c,v retrieving revision 1.4 diff -u -r1.4 mathfunc.c --- Src/Modules/mathfunc.c 2 Jun 2004 22:15:00 -0000 1.4 +++ Src/Modules/mathfunc.c 8 Jun 2004 21:42:14 -0000 @@ -500,7 +500,7 @@ * to each unsigned short. */ for (i = 0; i < 3 && !do_init; i++) { - unsigned short *seedptr = seedbuf + i; + unsigned short *seedptr = seedbufptr + i; *seedptr = 0; for (j = 0; j < 4; j++) { if (*seedstr >= '0' && *seedstr <= '9') -- Peter Stephenson Work: pws@csr.com Web: http://www.pwstephenson.fsnet.co.uk