From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19401 invoked from network); 12 Jul 2004 17:54:38 -0000 Received: from odin.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.85) by ns1.primenet.com.au with SMTP; 12 Jul 2004 17:54:38 -0000 Received: (qmail 21626 invoked from network); 12 Jul 2004 17:57:37 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 12 Jul 2004 17:57:37 -0000 Received: (qmail 11933 invoked by alias); 12 Jul 2004 17:54:08 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20153 Received: (qmail 11924 invoked from network); 12 Jul 2004 17:54:08 -0000 Received: from odin.dotsrc.org (HELO a.mx.sunsite.dk) (qmailr@130.225.247.85) by sunsite.dk with SMTP; 12 Jul 2004 17:54:08 -0000 Received: (qmail 21474 invoked from network); 12 Jul 2004 17:57:34 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 12 Jul 2004 17:57:21 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i6CHrRv26126 for ; Mon, 12 Jul 2004 17:53:28 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Mon, 12 Jul 2004 18:52:46 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 12 Jul 2004 18:54:39 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i6CHrQDW008335 for ; Mon, 12 Jul 2004 18:53:26 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i6CHrQtD008332 for ; Mon, 12 Jul 2004 18:53:26 +0100 Message-Id: <200407121753.i6CHrQtD008332@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: Bug with the new prompt redraw code In-reply-to: "Bart Schaefer"'s message of "Mon, 12 Jul 2004 09:28:13 PDT." Date: Mon, 12 Jul 2004 18:53:26 +0100 From: Peter Stephenson X-OriginalArrivalTime: 12 Jul 2004 17:54:39.0240 (UTC) FILETIME=[4D4AF880:01C46839] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 Bart Schaefer wrote: > On Sun, 11 Jul 2004, Peter Stephenson wrote: > > > > > > (1) zle-line-init runs before the prompt is displayed > > So, what about (1)? To repeat, the intent was to display a multi-line > prompt immediately after a command finishes, but then refresh only the > last line of that prompt on subsequent zle redisplays (the original > example involved SIGWINCH handling). > > An almost-equivalent thing can be achieved by using "print -P" from the > precmd function instead of by assignment to PS1, but there's a question > of whether other commands in zle-line-init should affect values that are > substituted into the prompt (e.g. $psvar). It sounds like zrefresh() should be moved earlier, out of zlecore(). This means zle-line-init is basically the last thing executed before the editor starts looking for input. Hence zle-line-init will only affect the next prompt, but the previous prompt will have been drawn. Maybe that's right. Index: Src/Zle/zle_main.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_main.c,v retrieving revision 1.48 diff -u -r1.48 zle_main.c --- Src/Zle/zle_main.c 11 Jul 2004 22:53:04 -0000 1.48 +++ Src/Zle/zle_main.c 12 Jul 2004 17:48:57 -0000 @@ -680,8 +680,6 @@ FD_ZERO(&foofd); #endif - zrefresh(); - while (!done && !errflag) { statusline = NULL; @@ -834,6 +832,8 @@ initmodifier(&zmod); prefixflag = 0; + zrefresh(); + if ((initthingy = rthingy_nocreate("zle-line-init"))) { char *args[2]; args[0] = initthingy->nam; @@ -1303,6 +1303,7 @@ { int locerror; + zrefresh(); zlecore(); locerror = errflag; -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************