zsh-workers
 help / color / mirror / code / Atom feed
From: Geoff Wing <gcw@zsh.org>
To: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: Another completion-time screen refresh bug
Date: Thu, 15 Jul 2004 15:51:43 +1000	[thread overview]
Message-ID: <20040715055143.GA15329@primenet.com.au> (raw)
In-Reply-To: <20040715033750.GA5837@primenet.com.au>

Tracked down to Src/Zle/compresult.c:printlist():2027-2028
This seems wrong - it's a near copy of compprintlist() (or the
other way around) but it doesn't necessarily make sense here.
Printing the new line only makes sense _after_ printing other
stuff which is OK in compprintlist() where there are possibly
multiple sets of lists & explanations to print.  Don't know if
this is the case here.

I don't (want to) understand this section.  I'm thinking that
those lines should be ripped out though maybe it should be
something like the following.  Anybody (besides Sven) looked
through this code before?

Regards,
Geoff

--- Src/Zle/compresult.c	2004-07-13 04:31:41.000000000 +1000
+++ Src/Zle/compresult.c	2004-07-15 15:40:41.000000000 +1000
@@ -1855,8 +1855,7 @@
 	if (tccan(TCCLEAREOD))
 	    tcout(TCCLEAREOD);
     }
-    g = amatches;
-    while (g) {
+    for (g = amatches; g; g = g->next) {
 	char **pp = g->ylist;
 
 	if ((e = g->expls)) {
@@ -2023,10 +2022,10 @@
 			    p = skipnolist(p + 1, showall);
 		}
 	    }
-	}
+	} else
+	    continue;
 	if (g->lcount || (showall && g->mcount))
 	    pnl = 1;
-	g = g->next;
     }
     lastlistlen = 0;
     if (clearflag) {


      reply	other threads:[~2004-07-15  5:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-31 16:47 Bart Schaefer
2004-07-13  2:02 ` Geoff Wing
2004-07-13  4:48   ` Bart Schaefer
2004-07-13  5:09     ` Bart Schaefer
2004-07-13  6:39     ` Geoff Wing
2004-07-13 15:17       ` Bart Schaefer
2004-07-15  3:37         ` Geoff Wing
2004-07-15  5:51           ` Geoff Wing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040715055143.GA15329@primenet.com.au \
    --to=gcw@zsh.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).