From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Util/helpfiles - problem with provided example
Date: Thu, 29 Jul 2004 16:40:50 +0100 [thread overview]
Message-ID: <200407291540.i6TFepHQ017657@news01.csr.com> (raw)
In-Reply-To: "Peter Stephenson"'s message of "Wed, 28 Jul 2004 11:01:15 BST." <200407281001.i6SA1FvF026186@news01.csr.com>
Peter Stephenson wrote:
> Edited down to bare essentials:
>
> Michael Prokop wrote:
> > man () {
> > man $1 # this is the original
> > }
> > $ man zsh
>
> > Segmentation fault
>
> This isn't very nice. Should we turn on --enable-max-function-depth by
> default? The default for --enable-max-function-depth=yes is 4096 which
> isn't going to hurt most people. Or should we make it configurable
> internally with a sensible default?
Here's a patch which turns it on by default.
Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.18
diff -u -r1.18 configure.ac
--- configure.ac 8 Jun 2004 13:34:12 -0000 1.18
+++ configure.ac 29 Jul 2004 15:39:00 -0000
@@ -301,12 +301,14 @@
AH_TEMPLATE([MAX_FUNCTION_DEPTH],
[Define for function depth limits])
AC_ARG_ENABLE(max-function-depth,
-[ --enable-max-function-depth=MAX limit function depth to MAX],
+[ --enable-max-function-depth=MAX limit function depth to MAX, default 4096],
[if test x$enableval = xyes; then
AC_DEFINE(MAX_FUNCTION_DEPTH, 4096)
-else
+elif test x$enableval != xno; then
AC_DEFINE_UNQUOTED(MAX_FUNCTION_DEPTH, $enableval)
-fi])
+fi],
+[AC_DEFINE(MAX_FUNCTION_DEPTH, 4096)]
+)
dnl Do you want to look for pcre support?
AC_ARG_ENABLE(pcre,
Index: INSTALL
===================================================================
RCS file: /cvsroot/zsh/zsh/INSTALL,v
retrieving revision 1.17
diff -u -r1.17 INSTALL
--- INSTALL 2 Jul 2004 15:59:11 -0000 1.17
+++ INSTALL 29 Jul 2004 15:39:01 -0000
@@ -330,6 +330,19 @@
`make uninstall' or `make uninstall.fns', although the version-specific
directory and its contents will be deleted.
+Function depth
+--------------
+
+Shell functions may be called recursively. In order to detect infinite
+recursion the shell has a limit on the depth to which functions may be
+called: note that this is a single limit for all functions, not a limit
+for each function called recursively. The default for the limit is 4096.
+The limit may be altered to the value MAX by passing the option
+--enable-max-function-depth=MAX to configure. Alternatively, the limit may
+be disabled with --disable-max-function-depth. However, this is not
+recommended as it is likely to cause the shell to crash on an infinite
+recursion.
+
Support for large files and integers
------------------------------------
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.
This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.
www.mimesweeper.com
**********************************************************************
prev parent reply other threads:[~2004-07-29 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-26 22:30 Michael Prokop
2004-07-28 10:01 ` Peter Stephenson
2004-07-28 10:21 ` Peter Stephenson
2004-07-29 15:40 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407291540.i6TFepHQ017657@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).