From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21224 invoked from network); 9 Aug 2004 09:52:52 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 9 Aug 2004 09:52:52 -0000 Received: (qmail 23490 invoked from network); 9 Aug 2004 09:52:46 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 9 Aug 2004 09:52:46 -0000 Received: (qmail 10624 invoked by alias); 9 Aug 2004 09:52:33 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20248 Received: (qmail 10609 invoked from network); 9 Aug 2004 09:52:32 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by 130.225.247.90 with SMTP; 9 Aug 2004 09:52:32 -0000 Received: (qmail 21155 invoked from network); 9 Aug 2004 09:50:36 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 9 Aug 2004 09:50:34 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i799oXv18428 for ; Mon, 9 Aug 2004 09:50:34 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id ; Mon, 9 Aug 2004 10:49:46 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 9 Aug 2004 10:52:58 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i799obar002907; Mon, 9 Aug 2004 10:50:37 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i799oaMM002904; Mon, 9 Aug 2004 10:50:36 +0100 Message-Id: <200408090950.i799oaMM002904@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk, 183730@bugs.debian.org Subject: Re: Bug#183730: zsh: setting SAVEHIST breaks history saving without warning In-reply-to: "Clint Adams"'s message of "Sun, 08 Aug 2004 01:21:33 EDT." <20040808052133.GA11833@scowler.net> Date: Mon, 09 Aug 2004 10:50:35 +0100 From: Peter Stephenson X-OriginalArrivalTime: 09 Aug 2004 09:52:58.0148 (UTC) FILETIME=[A6774E40:01C47DF6] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=-0.0 required=6.0 tests=BAYES_44 autolearn=no version=2.63 X-Spam-Hits: -0.0 Clint Adams wrote: > > Maybe there should be a truncation warning. > > > > 1% SAVEHIST=899795648511 > > 2% print $SAVEHIST > > 2147483647 > > 3% SAVEHIST=899795648512 > > 4% print $SAVEHIST > > Or an error? (Why does this `break history saving'? Or is the subject line inaccurate? I'll assume the latter for now.) I suspect there could be a lot of problems like this. History numbering ought to wrap gracefully, but I expect it doesn't. Also, arithmetic is done as a `zlong' which is probably 64 bits if the compiler supports it, while the history size and many other parameters are only 32 bits. Consequently there are lots of place which would need to change to make this sort of thing consistent, - the history code itself - where integers from arithmetic expresssions are assigned to variables (though maybe it would be more consistent to use zlong for parameters set by the user) - where numbers are originally parsed. The number assigned is obviously too large to be directly useful; what was the intention? Always save values at the end of the history list regardless of what was there already? -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************