From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@sunsite.dk
Subject: Re: ZLE and compsys miscellaneous
Date: Mon, 23 Aug 2004 23:53:56 -0700 [thread overview]
Message-ID: <20040824065356.GB6431@blorf.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0408172027580.842@toltec.zanshin.com>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Sun, Aug 22, 2004 at 03:37:33PM -0700, Bart Schaefer wrote:
> I just noticed that down-line-or-history and up-line-or-history don't
> behave as I expected when given a negative NUMERIC. They go up or down
> lines within the buffer as expected, but if there is no room to move in
> the buffer they use the absolute value of NUMERIC for the history motion.
Yeah. This also looks like it affects the {down,up}-line-or-search
functions as well. I think the upline()/downline() helper functions
in zle_hist.c need to negate the "n" value, as in the attached patch.
..wayne..
[-- Attachment #2: negate.patch --]
[-- Type: text/plain, Size: 391 bytes --]
--- Src/Zle/zle_hist.c 29 Jul 2004 14:22:22 -0000 1.14
+++ Src/Zle/zle_hist.c 24 Aug 2004 06:51:08 -0000
@@ -92,7 +92,7 @@ upline(void)
if (n < 0) {
zmult = -zmult;
- n = downline();
+ n = -downline();
zmult = -zmult;
return n;
}
@@ -176,7 +176,7 @@ downline(void)
if (n < 0) {
zmult = -zmult;
- n = upline();
+ n = -upline();
zmult = -zmult;
return n;
}
prev parent reply other threads:[~2004-08-24 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-22 22:37 Bart Schaefer
2004-08-24 6:53 ` Wayne Davison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824065356.GB6431@blorf.net \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).