zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
To: zsh-workers@sunsite.dk
Subject: Re: Test Failures from latest CVS
Date: Sun, 05 Sep 2004 18:36:27 +0100	[thread overview]
Message-ID: <20040905173628.A29CB8634@pwstephenson.fsnet.co.uk> (raw)
In-Reply-To: "Bart Schaefer"'s message of "Sat, 04 Sep 2004 09:38:26 PDT." <Pine.LNX.4.61.0409040927360.1742@toltec.zanshin.com>

Bart Schaefer wrote:
> The scriptname has to be changed before the string to be eval'd is parsed. 
> Peter tried (or so I presume) to fix a long-standing bug that scriptname 
> would not be restored properly on a parse error, by delaying the change 
> rather than by explicitly restoring; but also neglected to restore ineval 
> to its previous state in the same circumstance.

Thanks, that looks better.

> (Is there a reason not to 
> assign lastval in that case also?  It could simplify the code structure.)

I don't think there's a reason *not* to; it's just not necessary because
in any case on return from bin_eval it gets set to the 1 we just
returned.

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>
Work: pws@csr.com
Web: http://www.pwstephenson.fsnet.co.uk


  reply	other threads:[~2004-09-05 17:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-04  1:29 Vin Shelton
2004-09-04 15:11 ` Bart Schaefer
2004-09-04 16:38   ` Bart Schaefer
2004-09-05 17:36     ` Peter Stephenson [this message]
2004-09-05 18:12       ` Bart Schaefer
  -- strict thread matches above, loose matches on Subject: below --
2001-04-03  4:46 Test Failures from Latest CVS Vin Shelton
2001-04-03 11:22 ` Sven Wischnowsky
2001-04-04  3:16   ` Vin Shelton
     [not found]     ` <1010404153344.ZM32462@candle.brasslantern.com>
2001-04-04 21:24       ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040905173628.A29CB8634@pwstephenson.fsnet.co.uk \
    --to=pws@pwstephenson.fsnet.co.uk \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).