From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13711 invoked from network); 6 Sep 2004 12:10:27 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 6 Sep 2004 12:10:27 -0000 Received: (qmail 68159 invoked from network); 6 Sep 2004 12:10:22 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 6 Sep 2004 12:10:22 -0000 Received: (qmail 21177 invoked by alias); 6 Sep 2004 12:10:08 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20322 Received: (qmail 21163 invoked from network); 6 Sep 2004 12:10:07 -0000 Received: from unknown (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 6 Sep 2004 12:10:07 -0000 Received: (qmail 67422 invoked from network); 6 Sep 2004 12:09:08 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 6 Sep 2004 12:09:06 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i86C93v08648 for ; Mon, 6 Sep 2004 12:09:03 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Mon, 6 Sep 2004 13:08:10 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 6 Sep 2004 13:09:54 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i86C8t8O027562 for ; Mon, 6 Sep 2004 13:08:55 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i86C8trG027559 for ; Mon, 6 Sep 2004 13:08:55 +0100 Message-Id: <200409061208.i86C8trG027559@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: Any comments on users/7883 ? In-reply-to: References: Date: Mon, 06 Sep 2004 13:08:54 +0100 From: Peter Stephenson X-OriginalArrivalTime: 06 Sep 2004 12:09:54.0772 (UTC) FILETIME=[6B85A140:01C4940A] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=-0.0 required=6.0 tests=BAYES_44 autolearn=no version=2.63 X-Spam-Hits: -0.0 Bart Schaefer wrote: > It fixes a crash bug, so it should either get committed or someone should > deduce the better fix to which I alluded. Isn't this the correct fix? The problem with hn being NULL is because the later code uses is_builtin which assumes it isn't NULL. So we need to take account of is_builtin being set (from the previous time through the loop) at this point, too. The error message for 'command -v blub' is now `no such builtin: -v'. Is that correct? I don't see any documentation for the fact that the -v argument isn't handled when posixbuiltins is set. Index: Src/exec.c =================================================================== RCS file: /cvsroot/zsh/zsh/Src/exec.c,v retrieving revision 1.70 diff -u -r1.70 exec.c --- Src/exec.c 3 Sep 2004 09:47:49 -0000 1.70 +++ Src/exec.c 6 Sep 2004 12:01:24 -0000 @@ -1950,7 +1950,7 @@ break; } if (!(hn = builtintab->getnode(builtintab, cmdarg))) { - if (cflags & BINF_BUILTIN) { + if ((cflags & BINF_BUILTIN) || is_builtin) { zwarn("no such builtin: %s", cmdarg, 0); lastval = 1; opts[AUTOCONTINUE] = oautocont; -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************