Re: Any comments on users/7883 ?

[Peter Stephenson <pws@csr.com>]

=?iso-8859-1?q?Oliver=20Kiddle?= wrote:
>  --- Peter Stephenson <pws@csr.com> wrote: 
> 
> > The error message for 'command -v blub' is now `no such builtin: -v'.
> > Is that correct?  I don't see any documentation for the fact that the
> > -v argument isn't handled when posixbuiltins is set.
> 
> The POSIX specification for command -v says: "Otherwise, no output
> shall be written and the exit status shall reflect that the name was
> not found." So it shouldn't print an error message.

That's just because command -v wasn't recognised as a command with an
option.  It works properly when the shell gets that far.

> I would have thought that -v should be handled when posixbuiltins is
> set. It is only there because of POSIX to begin with.

I think this is the answer.  It may be just an oversight.  The second
hunk now doesn't get reached, but the change seems right anyway.

The test hn == (HashNode)&commandbn now gets an error message about
`dereferencing type-punned pointer', even though it's obviously never
dereferenced.

I still don't properly understand the logic here.

Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.70
diff -u -r1.70 exec.c
--- Src/exec.c	3 Sep 2004 09:47:49 -0000	1.70
+++ Src/exec.c	6 Sep 2004 13:15:17 -0000
@@ -1939,8 +1939,18 @@
 		return;
 	    }
 
+	    /*
+	     * Quit looking for a command
+	     * - if there was an error, or
+	     * - if we have checked that the hash entry is suitable, or
+	     * - if we are using the command prefix and either
+	     *   - we are not using POSIXBUILTINS, or
+	     *   - we have determined there are options which would
+	     *     require us to use the command builtin.
+	     */
 	    if (errflag || checked ||
-		(unset(POSIXBUILTINS) && (cflags & BINF_COMMAND)))
+		((cflags & BINF_COMMAND) &&
+		 (unset(POSIXBUILTINS) || hn == (HashNode)&commandbn)))
 		break;
 
 	    cmdarg = (char *) peekfirst(args);
@@ -1950,7 +1960,7 @@
 		break;
 	    }
 	    if (!(hn = builtintab->getnode(builtintab, cmdarg))) {
-		if (cflags & BINF_BUILTIN) {
+		if ((cflags & BINF_BUILTIN) || is_builtin) {
 		    zwarn("no such builtin: %s", cmdarg, 0);
 		    lastval = 1;
                     opts[AUTOCONTINUE] = oautocont;

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************