From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: Any comments on users/7883 ?
Date: Tue, 07 Sep 2004 11:25:02 +0100 [thread overview]
Message-ID: <200409071025.i87AP2BB002043@news01.csr.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0409062129020.13699@toltec.zanshin.com>
Bart Schaefer wrote:
> (It looks like nobody understands this code, me included. Did Zefram
> write it, originally?)
Probably, unless it's even older.
> This is the key bit here. I think the right fix is to check "is_builtin"
> not "hn == (HashNode)&commandbn" -- and that it's not necessary to && it
> with (cflags & BINF_COMMAND) the way you have.
This may be the best we're going to get.
> (Is it just me, or is there a crash waiting to happen at line 1828 in the
> event of a badly written module?)
You mean before the patch?
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070
**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.
This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.
www.mimesweeper.com
**********************************************************************
next prev parent reply other threads:[~2004-09-07 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-05 18:13 Bart Schaefer
2004-09-06 12:08 ` Peter Stephenson
2004-09-06 12:45 ` Oliver Kiddle
2004-09-06 13:15 ` Peter Stephenson
2004-09-07 5:24 ` Bart Schaefer
2004-09-07 10:25 ` Peter Stephenson [this message]
2004-09-08 7:37 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409071025.i87AP2BB002043@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).