From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24054 invoked from network); 7 Sep 2004 10:25:27 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 7 Sep 2004 10:25:27 -0000 Received: (qmail 10895 invoked from network); 7 Sep 2004 10:25:21 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 7 Sep 2004 10:25:21 -0000 Received: (qmail 15741 invoked by alias); 7 Sep 2004 10:25:18 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 20326 Received: (qmail 15726 invoked from network); 7 Sep 2004 10:25:18 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 7 Sep 2004 10:25:18 -0000 Received: (qmail 10596 invoked from network); 7 Sep 2004 10:25:18 -0000 Received: from lhuumrelay3.lnd.ops.eu.uu.net (62.189.58.19) by a.mx.sunsite.dk with SMTP; 7 Sep 2004 10:25:15 -0000 Received: from MAILSWEEPER01.csr.com (mailhost1.csr.com [62.189.183.235]) by lhuumrelay3.lnd.ops.eu.uu.net (8.11.0/8.11.0) with ESMTP id i87APDv07791 for ; Tue, 7 Sep 2004 10:25:13 GMT Received: from EXCHANGE02.csr.com (unverified [192.168.137.45]) by MAILSWEEPER01.csr.com (Content Technologies SMTPRS 4.3.12) with ESMTP id for ; Tue, 7 Sep 2004 11:24:19 +0100 Received: from news01.csr.com ([192.168.143.38]) by EXCHANGE02.csr.com with Microsoft SMTPSVC(5.0.2195.6713); Tue, 7 Sep 2004 11:26:06 +0100 Received: from news01.csr.com (localhost.localdomain [127.0.0.1]) by news01.csr.com (8.12.11/8.12.11) with ESMTP id i87AP3xl002046 for ; Tue, 7 Sep 2004 11:25:03 +0100 Received: from csr.com (pws@localhost) by news01.csr.com (8.12.11/8.12.11/Submit) with ESMTP id i87AP2BB002043 for ; Tue, 7 Sep 2004 11:25:03 +0100 Message-Id: <200409071025.i87AP2BB002043@news01.csr.com> X-Authentication-Warning: news01.csr.com: pws owned process doing -bs To: zsh-workers@sunsite.dk Subject: Re: Any comments on users/7883 ? In-reply-to: References: <20040906124533.58856.qmail@web25002.mail.ukl.yahoo.com> <200409061315.i86DFvFC028391@news01.csr.com> Date: Tue, 07 Sep 2004 11:25:02 +0100 From: Peter Stephenson X-OriginalArrivalTime: 07 Sep 2004 10:26:06.0564 (UTC) FILETIME=[15A24240:01C494C5] X-Spam-Checker-Version: SpamAssassin 2.63 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, hits=0.0 required=6.0 tests=none autolearn=no version=2.63 X-Spam-Hits: 0.0 Bart Schaefer wrote: > (It looks like nobody understands this code, me included. Did Zefram > write it, originally?) Probably, unless it's even older. > This is the key bit here. I think the right fix is to check "is_builtin" > not "hn == (HashNode)&commandbn" -- and that it's not necessary to && it > with (cflags & BINF_COMMAND) the way you have. This may be the best we're going to get. > (Is it just me, or is there a crash waiting to happen at line 1828 in the > event of a badly written module?) You mean before the patch? -- Peter Stephenson Software Engineer CSR Ltd., Science Park, Milton Road, Cambridge, CB4 0WH, UK Tel: +44 (0)1223 692070 ********************************************************************** This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This footnote also confirms that this email message has been swept by MIMEsweeper for the presence of computer viruses. www.mimesweeper.com **********************************************************************